DTL (Test > Levelbuilder): 5b1f22d7 #31163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in #27841 we attempted converting the markdown-based labels in the teacher application from MarkdownSpan to UnsafeRenderedMarkdown (which is happily now known as SafeMarkdown as of #29457). However, the red asterisks for required fields were apparently not showing in the right place, as evidenced by the work in #28152 to move them to the fronts of the questions. This change converts the same labels from MarkdownSpan to SafeMarkdown, but this time leaves the red asterisks at the ends of the labels. It does this by wrapping the label in a div named for whether the field is required or not, and then we use a little CSS trick to put the red asterisk at the end of the last <p> tag generated by the markdown for that label.
Rename teacher app sections
DTT (Staging > Test) [dave]
Make application front end components and file names year-agnostic
[student-libraries] Create util functions for parsing libraries
This reverts commit b2ae596.
…is-gone Revert "Check board is gone"
DTT (Staging > Test) [robo-dtt]
DTT (Staging > Test) [robo-dtt]
To make the forms look the same as before they used SafeMarkdown for labels, remove the bottom margin from the last <p> in a label.
Fix typo that was breaking CSP teacher applications
Teacher Application Detail View - Part 3
Drop AFE experiment flag on client and server side
…es-safe-markdown PL: Convert teacher application MarkdownSpan -> SafeMarkdown
I18n sync In & Up 10/07
DTT (Staging > Test) [robo-dtt]
…pplication-uses-safe-markdown Revert "PL: Convert teacher application MarkdownSpan -> SafeMarkdown"
DTT (Staging > Test) [robo-dtt]
…-expo-sdk-34 Export: upgrade to Expo SDK 34
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.