SoundsTest passes in ChromeHeadless #32518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
commented
Dec 20, 2019
|
|
||
| describe('Sounds', () => { | ||
| const sounds = new Sounds(); | ||
| const sourceURL = | ||
| 'studio.code.org/api/v1/sound-library/KyZOBksdJiQSlvoiOzFGpryJiMexdfks/category_ui/click1.mp3'; |
There was a problem hiding this comment.
This URL 404s, and where PhantomJS left its sound in a "still loading" state so that the test would pass, ChromeHeadless resolves the 404 right away and leaves the sound in a "load failed" state.
islemaster
commented
Dec 20, 2019
| @@ -1,11 +1,11 @@ | |||
| import {expect} from '../util/deprecatedChai'; | |||
| import Sounds from '@cdo/apps/Sounds'; | |||
| import sinon from 'sinon'; | |||
| import winMp3 from '!!file-loader!../audio/assets/win.mp3'; | |||
There was a problem hiding this comment.
I've fixed this by using Webpack's file-loader inline (which is nice because we don't really need this as part of our global config) to pull an existing fixture mp3 file from our repo, which is guaranteed to load unlike the broken URL below.
This was referenced Dec 20, 2019
7 tasks
jmkulwik
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to run tests in ChromeHeadless on my local machine, since PhantomJS isn't working properly on recent versions of Ubuntu. Eventually, I'd like us to use ChromeHeadless in our CI builds too, but to do that, we need to fix up all the tests that fail on this browser.
One of the tests that fails is
SoundsTest#does play URLs when unmuted. I believe this fixes that test under both ChromeHeadless and PhantomJS.Reviewer Checklist: