loadAppTest passes on ChromeHeadless #32522
Conversation
| const expectedPngSize = /PhantomJS/.test(window.navigator.userAgent) | ||
| ? 523181 // PhantomJS | ||
| : 38961; // ChromeHeadless | ||
| expect(blob).to.have.property('size', expectedPngSize); |
There was a problem hiding this comment.
It looks like ChromeHeadless writes a much, much smaller PNG than Phantom does. Unfortunately, this is a tough one to make work both ways without weakening this assertion somehow, so I'm going with a little browser detection. I'm open to pushback here - if we think we don't really care about the size of the generated PNG, we could just remove this assertion, or check that the size is at least 1k.
There was a problem hiding this comment.
Have you been able to visually inspect the PNG generated by ChromeHeadless to confirm that it's actually correct?
There was a problem hiding this comment.
Great question. I haven't for this case, but I'm going through a similar exercise for a different test that's comparing dataURIs, and while the PNG comes out correct, the difference in size is astounding.
| PhantomJS | ChromeHeadless |
|---|---|
| 523kB | 40kB |
 |
 |
I've been trying to run tests in ChromeHeadless on my local machine, since PhantomJS isn't working properly on recent versions of Ubuntu. Eventually, I'd like us to use ChromeHeadless in our CI builds too, but to do that, we need to fix up all the tests that fail on this browser.
One of the tests that fails is
loadAppTest project level share images uploads a share image for a non-droplet project (instead of writing the level). I believe this fixes that test under both ChromeHeadless and PhantomJS.See also
Reviewer Checklist: