imageUtilsTest passes on ChromeHeadless #32524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
commented
Dec 21, 2019
| // pass in both browsers. | ||
| const expectedPng = /PhantomJS/.test(window.navigator.userAgent) | ||
| ? expectedPhantomPng | ||
| : expectedChromePng; |
There was a problem hiding this comment.
Similar to the problem with loadAppTest, Chrome and Phantom generate visually similar images that are very different when you actually try to do a bytewise comparison.
| PhantomJS | ChromeHeadless |
|---|---|
| 523kB | 40kB |
 |
 |
davidsbailey
approved these changes
Dec 21, 2019
islemaster
force-pushed
the
imageutilstest-chromeheadless
branch
from
4b70080
to
f2c99c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to run tests in ChromeHeadless on my local machine, since PhantomJS isn't working properly on recent versions of Ubuntu. Eventually, I'd like us to use ChromeHeadless in our CI builds too, but to do that, we need to fix up all the tests that fail on this browser.
One of the tests that fails is
image utils overlays an image inside the Artist frame. I believe this fixes that test under both ChromeHeadless and PhantomJS.See also
Reviewer Checklist: