Add azure speech service keys #35210
Conversation
|
looking at the original PR again, it does look like we missed the linked change in config.yml.erb |
|
@uponthesun can we get your review this PR? i think we've added keys in the correct places (minus the one mentioned in my comment above, which we'll add), but i haven't gone through this process before. |
There was a problem hiding this comment.
Just want to double check, you've already added the secrets for each environment with these instructions? https://github.com/code-dot-org/code-dot-org/blob/staging/config/secrets.md#creatingupdating-a-secret
| @@ -214,6 +214,10 @@ firebase_max_table_rows: 20000 | |||
| firebase_max_record_size: 4096 | |||
| firebase_max_property_size: 4096 | |||
|
|
|||
| # Azure keys for speech service | |||
There was a problem hiding this comment.
config.yml.erb acts as the defaults across all environments, so if you want them in every environment, you should only need to add them here, and not in the development/staging/test/production/levelbuilder yml files. (It would still work the way it is right now, it's just redundant.)
yep! we added those last week, so they should be available in all environments. |
Adding the azure speech service keys for future use in the text to speech block.
Background
We are incrementally trying to merge this PR
Links
Reviewer Checklist: