Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text to speech block backend #35328

Merged
merged 7 commits into from
Jun 17, 2020
Merged

Text to speech block backend #35328

merged 7 commits into from
Jun 17, 2020

Conversation

JillianK
Copy link
Contributor

@JillianK JillianK commented Jun 15, 2020

Adding the text to speech block backend. Basically this requests an access token and passes it along to the frontend along with the service region. The token and service region will be used on the frontend to make requests to azure cognitive services for text to speech.

Background

We are incrementally trying to merge this PR after it broke staging when we tried to merge the entire thing. This was most likely due to a mistake with adding the secrets but we're taking our time just to be safe.
The secrets are already added to AWS Secrets Manager in this PR.

Links

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@jmkulwik
Copy link
Contributor

jmkulwik commented Jun 16, 2020

Can you add a little more to the description? Some things to consider:

  • Why are we splitting up the other PR?
  • What happens in this backend portion?
  • How will the backend interact with the other portions of the feature?
  • Are secrets being stored somewhere? (and were can we find them)

Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! I left a couple documentation questions, but none of it affects the code itself.

@JillianK JillianK merged commit 8c9c4a6 into staging Jun 17, 2020
@JillianK JillianK deleted the tts-backend-only branch June 17, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants