Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to instructions in HoC progression #54881

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Updates to instructions in HoC progression #54881

merged 7 commits into from
Nov 14, 2023

Conversation

fisher-alice
Copy link
Contributor

@fisher-alice fisher-alice commented Nov 14, 2023 •
edited

Levelbuilder editing is currently not working so these are updates to instructions from @katiejofr based on Karim's feedback. In anticipation of upcoming change to hint bubbles in instructions so that they will have blue border, this PR also adds blue lightbulb images to hints.

I checked locally to make sure changes look as expected.
Screencast video: I show validation feedback only on level 2.

strings-check.mp4

Links

Slack thread

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@fisher-alice fisher-alice requested review from breville and a team November 14, 2023 02:33
@fisher-alice fisher-alice marked this pull request as ready for review November 14, 2023 02:34
jmkulwik
jmkulwik reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has anyone synced with the international team to understand whether we can get these translated?

@fisher-alice
Copy link
Contributor Author

Has anyone synced with the international team to understand whether we can get these translated?

Yes - @samantha-code has.

@fisher-alice fisher-alice requested review from jmkulwik and a team November 14, 2023 14:03
Erin007
Erin007 reviewed Nov 14, 2023
View reviewed changes
dashboard/config/levels/custom/dance/dance_ai_generate_effect.level Outdated
"long_instructions": "**A.I. is here to find the best effect for your dance party!**\r\n\r\n<img src=\"https://images.code.org/4a3bd15e97f6dd79f9a57fc07ad79017-image-1697662602704.png\" style=\" margin-right: 40px; height: 100px; float: left\">\r\n\r\n- Connect the <code style=\"color:white; background-color:#566064\">AI generate effect</code> block to setup.\r\n\r\n- Click on the block to get started. \r\n",
"short_instructions": "**A.I. is here to find the best effect for your dance party!**\r\nConnect the `AI generate effect` block to setup then click on the block to get started.",
"long_instructions": "**A.I. can help you create fun visual effects for your dance party!**\r\n\r\n<img src=\"https://images.code.org/4a3bd15e97f6dd79f9a57fc07ad79017-image-1697662602704.png\" style=\" margin-right: 40px; height: 100px; float: left\">\r\n\r\n- Connect the <code style=\"color:white; background-color:#566064\">AI generate effect</code> block to setup.\r\n\r\n- Click on the block to get started. \r\n",
"short_instructions": "**A.I. can help you create fun visual effects for your dance party!**\r\nConnect the `AI generate effect` block to setup. Then click on the block to get started.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no preference on my end just confirming the inconsistency in A.I. v. AI is expected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm going to check with the team about this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much Erin! We do want consistency so I updated in three levels.

Erin007
Erin007 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from me as the outgoing DOTD on these strings, @fisher-alice 👍

thomasoniii
thomasoniii approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@thomasoniii thomasoniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@fisher-alice fisher-alice merged commit 76befbc into staging Nov 14, 2023
2 checks passed
@fisher-alice fisher-alice deleted the alice/katie-updates branch November 14, 2023 23:55
molly-moen added a commit that referenced this pull request Nov 15, 2023
@deploy-code-org @breville
@jmkulwik @davidsbailey @molly-moen @Nokondi @sanchitmalhotra126 @fisher-alice @dmcavoy @levadadenys @artem-vavilov @kelbyhawn @bencodeorg @TurnerRiley
DTT (Staging > Test) [robo-dtt] (#54949)
df86956 
* Tutorial explorer: preview mode on hourofcode.com

* Updated test to account for flakiness.

* Added comment

* Re-enabled test

* hoc2023: AI string updates

* Use use_preview variable

* Update schema cache dump after schema changes.

* Require script_id for SingleSectionExperiment and TeacherBasedExperiment (#54843)

* require script_id on SingleSectionExperiment and TeacherBasedExperiment

* fix and improve unit tests

* fix unit tests

* revert stray schema changes

* Update string and font size

* Split lines for explanation text.

* update injection options (#54818)

* Handle pending and error states for rubric ai evaluation (#54860)

* updated rubric for more useful error messages

* updated rubric settings tests for new errors

* undo debug changes to rubrics_controller

* bug fixes

* added messages for pending and running states

* Dance AI: Add start over button (#54899)

* Dance AI: Add start over button

* don't show on explanation page, add tooltips

* Updates to instructions in HoC progression (#54881)

Updates to instructions in HoC progression

* Allow setting workshop organizer permission (#54896)

* Allow setting workshop organizer permission

* Update Assignable Permissions

* added categories and standards csv files (#54933)

* levelbuilder content changes (-robo-commit)

* staging content changes (-robo-commit)

* * removed empty files on dashboard/public/fonts/gotham (#54906)

* P20-522: Fix Express22 level (#54789)

* P20-522: Translate `gamelab_ifVarEquals` block type NUM vsriables

* P20-522: Translate `procedures_defnoreturn` block id attr

* Revert "P20-522: Translate `procedures_defnoreturn` block id attr"

This reverts commit e0f4280.

* [DESign2-51] Add Chips component (#54064)

* Created Chips component
* created stories for Chips
* created tests for Chips
* created documentation for Chips
* removed MultiSelectGroup
* used Chips instead of MultiSelectGroup in the code

* Teachers find course button goes to catalog (#54918)

* Teachers find course button goes to catalog

* update test

* staging content changes (-)

* HoC 2023 - Fix missing string on Educators How-to guide (#54932)

* Add skinny banner to code.org/student/middle-high for AFE scholarships (#54907)

* refactor middle-high.haml and remove stylesheet

* add afe_scholarship_skinny_banner.haml view

* update grade labels and add empty alt text to images

* Dance AI: handle RTL in header, footer, and effect/code toggle (#54922)

* * add focus state for toggle code/effect buttons

* * dance ai - explanation area RTL support fixes

* * dance party - song selector RTL support fix

* * updated explanation button rtl languages positioning
* added comment (review fix)

* Center toggle in LTR/RTL, force LTR header even in RTL languages

* RTL header

* Handle RTL in footer buttons

* Fix text/icon spacing in RTL

* Undo spacing change

* Use div instead of span

---------

Co-authored-by: denyslevada <levada.denys@gmail.com>

* standardize counting of events so all are right (#54927)

* Update Neural Networks lesson text on code.org/ai/how-ai-works and hourofcode.com/ai (#54915)

* Update code.org/hourofcode see all Hour of code tutorials section (#54931)

* add see all activities section

* update images and add responsive styles

---------

Co-authored-by: breville <brendan@code.org>
Co-authored-by: Jessica Kulwik <jessica@code.org>
Co-authored-by: Dave Bailey <davidsbailey@users.noreply.github.com>
Co-authored-by: Molly Moen <molly@code.org>
Co-authored-by: Mark Barnes <mark.barnes@code.org>
Co-authored-by: Sanchit Malhotra <85528507+sanchitmalhotra126@users.noreply.github.com>
Co-authored-by: fisher-alice <107423305+fisher-alice@users.noreply.github.com>
Co-authored-by: Brendan Reville <breville@users.noreply.github.com>
Co-authored-by: Dani LaMarca <dani@code.org>
Co-authored-by: levadadenys <levada.denys@gmail.com>
Co-authored-by: Artem Vavilov <11708250+artem-vavilov@users.noreply.github.com>
Co-authored-by: Kelby Hawn <9256643+kelbyhawn@users.noreply.github.com>
Co-authored-by: bencodeorg <ben@code.org>
Co-authored-by: Turner Riley <56283563+TurnerRiley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasoniii thomasoniii thomasoniii approved these changes

@Erin007 Erin007 Erin007 approved these changes

@breville breville Awaiting requested review from breville

@jmkulwik jmkulwik Awaiting requested review from jmkulwik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fisher-alice @thomasoniii @jmkulwik @Erin007