Skip to content
This repository has been archived by the owner on Jan 29, 2021. It is now read-only.

Extract components, mock endpoints #47

Merged
merged 15 commits into from
Mar 19, 2018

Conversation

enlore
Copy link
Collaborator

@enlore enlore commented Mar 18, 2018

No description provided.

Copy link
Contributor

@mshenfield mshenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a test expecting Hello.vue, causing the Travis.CI to fail here. Should be a quick fix.

Copy link
Contributor

@mshenfield mshenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would rather the commented out tests just be deleted, we can always use git log to see what was.

@@ -1,11 +1,17 @@
import Vue from 'vue'
import Hello from '@/components/Hello'
// import Vue from 'vue'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

})
})

// describe('Hello.vue', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

@enlore enlore merged commit 75633ce into code-for-nashville:develop Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants