Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin execution should be a graceful exit and run all registered plugins before throwing #159

Closed
BioPhoton opened this issue Oct 25, 2023 · 0 comments · Fixed by #275
Closed

plugin execution should be a graceful exit and run all registered plugins before throwing #159

BioPhoton opened this issue Oct 25, 2023 · 0 comments · Fixed by #275
Assignees
@MishaSeredenkoPushBased
Labels
🧩 core ➕ enhancement new feature or request 💡 good first issue good for newcomers 🤓 UX UX improvement for CLI users
Milestone
2. Integration

Comments

@BioPhoton
Copy link
Collaborator

BioPhoton commented Oct 25, 2023 •
edited by kristihoskova
Loading

Use promise settled and log the promise result.
@BioPhoton BioPhoton added ➕ enhancement new feature or request 🤓 UX UX improvement for CLI users 🧩 core 💡 good first issue good for newcomers labels Oct 25, 2023
@kristihoskova kristihoskova added this to the 2. Integration milestone Nov 13, 2023
MishaSeredenkoPushBased added a commit that referenced this issue Nov 16, 2023
@MishaSeredenkoPushBased
feat(core): change to execute all plugins before throwing on failed
bfdb2f2 
closes #159

#159
Merged
MishaSeredenkoPushBased added a commit that referenced this issue Nov 22, 2023
@MishaSeredenkoPushBased
feat(core): change to execute all plugins before throwing on failed (#…
32a6ef5 
…275)

Changed executePlugins() logic to run all plugins, even if one or more
plugins have failed. Then console.error the failed plugin errors, and
throw.
Closes #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MishaSeredenkoPushBased MishaSeredenkoPushBased

Labels
🧩 core ➕ enhancement new feature or request 💡 good first issue good for newcomers 🤓 UX UX improvement for CLI users
Projects
None yet
Milestone
2. Integration
Development

Successfully merging a pull request may close this issue.

feat(core): change to execute all plugins before throwing on failed code-pushup/cli
3 participants
@BioPhoton @kristihoskova @MishaSeredenkoPushBased