feat(core): add history logic #541

BioPhoton · 2024-03-05T21:28:10Z

This PR is related to the history command and part of #216 and adds the history logic to core.

It includes the following logic:

prepareHashes - logic to get the commit hash from a list of logs
getHashes - logic to get a list of hashes based on options from, to, maxCount
history - the history logic that checks out all commits and runs collect and optionally upload

Testing:

Added unit tests and integration tests. For the integration tests I used a separate git folder to avoid the flaky test. I thing we should document that somewhere?

nx-cloud · 2024-03-05T21:28:52Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dcd5ff9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

packages/core/src/lib/history.ts

packages/core/src/lib/history.unit.test.ts

Tlacenka

Has potential!

Thank you for the PR description 🙏

packages/core/src/lib/history.integration.test.ts

packages/core/src/lib/history.ts

packages/core/src/lib/history.unit.test.ts

packages/core/src/lib/history.integration.test.ts

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

# Conflicts: # packages/utils/src/index.ts

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

packages/core/src/lib/history.ts

packages/core/src/lib/history.unit.test.ts

packages/core/src/lib/history.ts

Tlacenka

A few minor suggestions, otherwise looking good!

packages/core/src/lib/history.ts

packages/core/src/lib/history.unit.test.ts

packages/core/src/lib/history.integration.test.ts

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

testing/test-utils/src/lib/utils/minimal-config.mock.ts

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

feat(core): add history logic

580d00b

github-actions bot assigned BioPhoton Mar 5, 2024

github-actions bot added 🔬 testing writing tests 🧩 core 🧩 utils 🛠️ tooling labels Mar 5, 2024

test(core): change test folder

79709e9

BioPhoton marked this pull request as ready for review March 5, 2024 21:32

BioPhoton requested review from matejchalk and Tlacenka March 6, 2024 10:49

matejchalk reviewed Mar 6, 2024

View reviewed changes

Tlacenka reviewed Mar 6, 2024

View reviewed changes

BioPhoton and others added 17 commits March 7, 2024 19:48

Update packages/core/src/lib/history.ts

f784519

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Update packages/core/src/lib/history.ts

12cc764

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Update packages/core/src/lib/history.ts

53e4204

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Update packages/core/src/lib/history.ts

34c5eab

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Update packages/core/src/lib/history.unit.test.ts

5f63434

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Update packages/core/src/lib/history.unit.test.ts

0df0367

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

refactor(core): adjust history logic

fa026f7

Update packages/core/src/lib/history.unit.test.ts

afd4b7b

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

Update packages/core/src/lib/history.unit.test.ts

d0c72d6

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

Update packages/core/src/lib/history.unit.test.ts

a982f38

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

Update packages/core/src/lib/history.integration.test.ts

2390060

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

Update packages/core/src/lib/history.integration.test.ts

634cde2

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

Update packages/core/src/lib/history.integration.test.ts

5d8cb50

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

Update packages/core/src/lib/history.integration.test.ts

fb3b1dc

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

test(core): adjust history tests

b122e4d

Merge branch 'main' into add-history-logic-to-core

9a2864b

# Conflicts: # packages/utils/src/index.ts

test(utils): adjust helper

3b1c58e

BioPhoton and others added 5 commits March 7, 2024 21:32

Update packages/core/src/lib/history.unit.test.ts

1b388f0

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

refactor(core): remove getHashed

42f8245

refactor(core): add LogOptions to history options

b7e318f

revert

340484e

refactor(core): adjust test logic

ebf5035

BioPhoton requested a review from matejchalk March 7, 2024 22:42

matejchalk previously approved these changes Mar 8, 2024

View reviewed changes

packages/core/src/lib/history.ts Outdated Show resolved Hide resolved

packages/core/src/lib/history.unit.test.ts Outdated Show resolved Hide resolved

packages/core/src/lib/history.ts Outdated Show resolved Hide resolved

Tlacenka reviewed Mar 8, 2024

View reviewed changes

Update packages/core/src/lib/history.ts

262317b

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

BioPhoton dismissed matejchalk’s stale review via 262317b March 8, 2024 14:10

BioPhoton and others added 6 commits March 8, 2024 15:10

Update packages/core/src/lib/history.ts

9e796cb

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

Update packages/core/src/lib/history.unit.test.ts

48327d6

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

Update packages/core/src/lib/history.unit.test.ts

a4c35a1

Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>

test(plugin-lighthouse): adjust tests

b6f62bd

test(plugin-lighthouse): adjust tests

913a545

refactor: adjust typing

dcd5ff9

BioPhoton requested review from Tlacenka and matejchalk March 9, 2024 20:38

matejchalk previously approved these changes Mar 11, 2024

View reviewed changes

testing/test-utils/src/lib/utils/minimal-config.mock.ts Outdated Show resolved Hide resolved

Update minimal-config.mock.ts

c9aaa3a

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

BioPhoton dismissed matejchalk’s stale review via c9aaa3a March 11, 2024 11:36

BioPhoton requested review from matejchalk and removed request for Tlacenka March 11, 2024 12:35

matejchalk approved these changes Mar 11, 2024

View reviewed changes

Tlacenka approved these changes Mar 11, 2024

View reviewed changes

BioPhoton merged commit 10df94c into main Mar 11, 2024
18 checks passed

BioPhoton deleted the add-history-logic-to-core branch March 11, 2024 18:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): add history logic #541

feat(core): add history logic #541

BioPhoton commented Mar 5, 2024 •

edited

Loading

nx-cloud bot commented Mar 5, 2024 •

edited

Loading

Tlacenka left a comment •

edited

Loading

Tlacenka left a comment

feat(core): add history logic #541

feat(core): add history logic #541

Conversation

BioPhoton commented Mar 5, 2024 • edited Loading

nx-cloud bot commented Mar 5, 2024 • edited Loading

☁️ Nx Cloud Report

Tlacenka left a comment • edited Loading

Choose a reason for hiding this comment

Tlacenka left a comment

Choose a reason for hiding this comment

BioPhoton commented Mar 5, 2024 •

edited

Loading

nx-cloud bot commented Mar 5, 2024 •

edited

Loading

Tlacenka left a comment •

edited

Loading