-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nx-plugin): rename autorun to cli executor #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📖 Project documentation
improvements or additions to the project documentation
🔬 testing
writing tests
🧩 nx-plugin
🛠️ tooling
labels
Aug 14, 2024
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 04ab516 with source commit c420a68. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 3 groups regressed, 👍 3 audits improved, 👎 8 audits regressed, 12 audits changed without impacting score🗃️ Groups
16 other groups are unchanged. 🛡️ Audits
490 other audits are unchanged. |
# Conflicts: # nx.json
# Conflicts: # e2e/nx-plugin-e2e/tests/create-nodes-plugin.e2e.test.ts # packages/nx-plugin/src/plugin/target/executor-target.ts
# Conflicts: # e2e/nx-plugin-e2e/tests/__snapshots__/create-nodes-plugin.e2e.test.ts.snap # e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts # nx.json # packages/nx-plugin/package.json # packages/nx-plugin/src/executors/cli/executor.ts
BioPhoton
changed the title
refactor(nx-plugin): autorun to general command executor
refactor(nx-plugin): rename autorun to cli executor
Aug 29, 2024
# Conflicts: # e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts
# Conflicts: # packages/models/package.json
matejchalk
reviewed
Oct 15, 2024
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
BioPhoton
commented
Oct 15, 2024
matejchalk
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧩 nx-plugin
📖 Project documentation
improvements or additions to the project documentation
🔬 testing
writing tests
🛠️ tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precondition:
Blocked until e2e tests are usable:
This PR
Renames the
autorun
executor tocli
It includes:
Closes #769