Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nx-plugin): rename autorun to cli executor #795

Merged
merged 38 commits into from
Oct 16, 2024

Conversation

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin 🛠️ tooling labels Aug 14, 2024
Copy link

github-actions bot commented Aug 14, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 04ab516 with source commit c420a68.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 52 🔴 42 ↓ −9.7
Updates 🟡 77 🟡 75 ↓ −2.1
Security 🟡 82 🟡 82 ↑ +0.8
Code coverage 🟢 90 🟡 90 ↓ −0.3
Custom checks 🟡 67 🟡 67
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 1 group improved, 👎 3 groups regressed, 👍 3 audits improved, 👎 8 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 52 🔴 42 ↓ −9.7
JS Packages NPM outdated dependencies 🟡 77 🟡 75 ↓ −2.1
JS Packages NPM audit 🟡 82 🟡 82 ↑ +0.8
Code coverage Code coverage metrics 🟢 90 🟡 90 ↓ −0.3

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.2 s 🟥 4.2 s ↑ +33.3 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.6 s ↑ +14.2 %
Lighthouse First Meaningful Paint 🟨 3.2 s 🟨 3.6 s ↑ +14.2 %
Lighthouse Speed Index 🟥 6.4 s 🟥 7.1 s ↑ +10.6 %
JS Packages Vulnerabilities for NPM dev dependencies. 🟥 13 vulnerabilities (4 high, 9 moderate) 🟥 12 vulnerabilities (4 high, 8 moderate) ↓ −7.7 %
JS Packages Outdated NPM prod dependencies. 🟨 13 outdated package versions (4 major, 4 minor, 5 patch) 🟨 15 outdated package versions (5 major, 5 minor, 5 patch) ↑ +15.4 %
Lighthouse Time to Interactive 🟥 19.6 s 🟥 18.8 s ↓ −3.8 %
Code coverage Line coverage 🟩 91.5 % 🟩 90.7 % ↓ −0.9 %
JS Packages Outdated NPM dev dependencies. 🟨 58 outdated package versions (33 major, 16 minor, 1 preminor, 7 patch, 1 prerelease) 🟨 58 outdated package versions (33 major, 16 minor, 1 preminor, 7 patch, 1 prerelease)  +0 %
Code coverage Branch coverage 🟨 85.4 % 🟨 84.8 % ↓ −0.7 %
Code coverage Function coverage 🟩 92.4 % 🟩 92.3 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,823 KiB 🟩 Total size was 1,818 KiB ↓ −0.2 %
Lighthouse Max Potential First Input Delay 🟥 4,900 ms 🟥 3,710 ms ↓ −24.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −3.8 %
Lighthouse Minimizes main-thread work 🟥 24.3 s 🟥 23.8 s ↓ −2.1 %
Lighthouse Total Blocking Time 🟥 9,650 ms 🟥 9,240 ms ↓ −4.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,270 ms 🟥 Potential savings of 1,120 ms ↓ −12 %
Lighthouse Initial server response time was short 🟩 Root document took 410 ms 🟩 Root document took 330 ms ↓ −20.2 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 100 ms ↑ +383.9 %
Lighthouse Server Backend Latencies 🟩 150 ms 🟩 80 ms ↓ −49 %
Lighthouse JavaScript execution time 🟥 11.8 s 🟥 11.7 s ↓ −0.2 %
Lighthouse Avoids an excessive DOM size 🟥 2,250 elements 🟥 2,239 elements ↓ −0.5 %

490 other audits are unchanged.

# Conflicts:
#	e2e/nx-plugin-e2e/tests/create-nodes-plugin.e2e.test.ts
#	packages/nx-plugin/src/plugin/target/executor-target.ts
# Conflicts:
#	e2e/nx-plugin-e2e/tests/__snapshots__/create-nodes-plugin.e2e.test.ts.snap
#	e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts
#	nx.json
#	packages/nx-plugin/package.json
#	packages/nx-plugin/src/executors/cli/executor.ts
@BioPhoton BioPhoton changed the title refactor(nx-plugin): autorun to general command executor refactor(nx-plugin): rename autorun to cli executor Aug 29, 2024
@BioPhoton BioPhoton marked this pull request as ready for review October 14, 2024 15:36
e2e/cli-e2e/tests/__snapshots__/help.e2e.test.ts.snap Outdated Show resolved Hide resolved
packages/nx-plugin/src/executors/cli/README.md Outdated Show resolved Hide resolved
packages/nx-plugin/src/executors/cli/schema.json Outdated Show resolved Hide resolved
packages/nx-plugin/src/executors/internal/types.ts Outdated Show resolved Hide resolved
packages/nx-plugin/src/plugin/README.md Outdated Show resolved Hide resolved
packages/nx-plugin/src/plugin/README.md Outdated Show resolved Hide resolved
packages/nx-plugin/src/plugin/README.md Outdated Show resolved Hide resolved
tools/src/publish/bin/bump-package.ts Outdated Show resolved Hide resolved
BioPhoton and others added 6 commits October 15, 2024 10:25
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton BioPhoton merged commit ee243ac into main Oct 16, 2024
16 checks passed
@BioPhoton BioPhoton deleted the refactor-to-command-executor branch October 16, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 nx-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx executor shouldn't assume autorun
2 participants