Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new UI bug #1325

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix new UI bug #1325

merged 1 commit into from
Sep 25, 2024

Conversation

shaurya35
Copy link
Contributor

PR Fixes:

  • Fixed the issue where the video player was taking so much space that its part was being cut when on higher resolution

Old UI

Screenshot 2024-09-19 035109

New UI

Screenshot 2024-09-19 034848

Responsiveness?

Screenshot 2024-09-19 034930

What does it Resolve?

  • For devices with a width greater than 1280px, the path and the button are on the same line.
  • For all others, it's the same as it is.

What is changed?

  • For 'xl' size and above, the CSS property changed to absolute and overlapped the button component.
  • Made the z-index of button 50 to it to work.
  • Tested in many scenarios.

### Open for any other Suggestions or Changes

Resolves #1180

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@shaurya35 shaurya35 mentioned this pull request Sep 25, 2024
Closed
@devsargam devsargam merged commit 3555bf3 into code100x:main Sep 25, 2024
@devsargam
Copy link
Collaborator

Thank you sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: new ui bug
2 participants
@shaurya35 @devsargam