Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Laravel 6.4 #7

Closed
wants to merge 5 commits into from
Closed

Support for Laravel 6.4 #7

wants to merge 5 commits into from

Conversation

rechl
Copy link

@rechl rechl commented Oct 24, 2019

No description provided.

@dvlpp
Copy link
Member

dvlpp commented Oct 24, 2019

I have 2 concerns:

  • it seems that this PR is containing more than juste the 6.4 support (something about adding a login button?)
  • and why don't we simply put 6.* as Laravel dependency (since it's semver now)?

@rechl
Copy link
Author

rechl commented Oct 24, 2019

Thanks for your fast reply! The login button was included by an error.

  • Login Button: I added it on our projects since some customers didn't know how to login. This should have been done with an separate PR/ and additional syles...

  • Yes 6.* should do it.

@rechl rechl closed this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rechl @dvlpp