Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer hover effect #1152

Merged
merged 6 commits into from
Feb 19, 2021
Merged

Footer hover effect #1152

merged 6 commits into from
Feb 19, 2021

Conversation

ww2497
Copy link
Member

@ww2497 ww2497 commented Feb 7, 2021

resolves #1093

@ww2497 ww2497 added the BH7 label Feb 7, 2021
@ww2497 ww2497 requested a review from peterkos February 7, 2021 04:38
@ww2497 ww2497 self-assigned this Feb 7, 2021
ghost
ghost reviewed Feb 9, 2021
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has been automatically deployed to FeaturePeek. 🎊
Your deployment will be kept up-to-date with this pull request's latest changes.

https://peek.run/3kqhzm24

Please read our docs for more configuration details.

peterkos
peterkos requested changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@peterkos peterkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!
Although can we have the links on hover change to $red insteaad of transforming? Transforms might look better under block elements and we can use color for inline; I'm planning the same thing for the updated schedule design and is what the current schedule uses but a bit less

index.html Show resolved Hide resolved
@ww2497
Copy link
Member Author

ww2497 commented Feb 11, 2021

Nice change!
Although can we have the links on hover change to $red insteaad of transforming? Transforms might look better under block elements and we can use color for inline; I'm planning the same thing for the updated schedule design and is what the current schedule uses but a bit less

Alright, I'll see how that effect looks. I did the translate effect because that's apparently what design wanted according to the issue.

@ww2497 ww2497 requested a review from peterkos February 13, 2021 06:46
peterkos
peterkos requested changes Feb 13, 2021
View reviewed changes
Copy link
Contributor

@peterkos peterkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other tweak: Translate effect for logos should be put back -- having logos change color on hover is a branding guideline issue!

index.html Outdated Show resolved Hide resolved
sass/main.scss Show resolved Hide resolved
@ww2497 ww2497 requested a review from peterkos February 16, 2021 02:24
peterkos
peterkos approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@peterkos peterkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ww2497 ww2497 merged commit 71afc48 into develop Feb 19, 2021
@ww2497 ww2497 deleted the bh-1093 branch February 19, 2021 06:16
peterkos pushed a commit that referenced this pull request Aug 4, 2021
@ww2497
Merge pull request #1152 from codeRIT/bh-1093
7d01343 
Footer hover effect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterkos peterkos peterkos approved these changes

Assignees

@ww2497 ww2497

Labels
BH7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make contact us section have some sort of hover effect
2 participants
@ww2497 @peterkos