[Issue 179] Adding a test for the osprojects model #184
Conversation
Codecov Report
@@ Coverage Diff @@
## main #184 +/- ##
=======================================
Coverage ? 82.21%
=======================================
Files ? 34
Lines ? 568
Branches ? 0
=======================================
Hits ? 467
Misses ? 101
Partials ? 0 Continue to review full report at Codecov.
|
| @@ -7,6 +7,7 @@ | |||
| from tagging.managers import CustomTaggableManager | |||
| from tagging.models import CustomTag, TaggedItems | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Note: my linter caused this extra line, but not sure why it's appearing π€
There was a problem hiding this comment.
Apologies for the brain fart and not reviewing this sooner! I think your linter is enforcing some sort of PEP 8 thing where imports are separated from code by two lines? Dunno. Weird.
| """ Test OSProjects model """ | ||
| # create OSProjects model instance | ||
| osproject = OSProjectsFactory(title="Buddybot", guid="cc63f918-d515-11ea-956f-0242ac130002") | ||
| assert osproject.title == "Buddybot" |
There was a problem hiding this comment.
Note: was thinking I could add more asserts here, but was wondering if this might also be fine
There was a problem hiding this comment.
Up to you. I usually go for an entire record -- or even two, then pick up to four things to assert. But even one assert proves it was inserted into the DB, which is what we are going for here....so.....
lpatmo
changed the title
There was a problem hiding this comment.
I think this works. You could get more elaborate, or even update data and check to make sure it works. Although that's getting into re-testing the ORM territory. I think this is probably "good enough" for a first pass at a model test for OSProjects. We can revisit as we get more of the endpoint done.
|
Thank you for reviewing, @BethanyG!! Will merge this in... and as you said, revisit/update as we get more of the endpoint done. |
What type of PR is this? (check all applicable)
Context
Tests the
osprojectsmodel we created! Two todos:[x] Cleared up this issue:
osprojects/tests.py::test_osprojects_model /usr/local/lib/python3.7/site-packages/django/db/models/fields/__init__.py:1363: RuntimeWarning: DateTimeField OSProjects.modified received a naive datetime (2020-05-31 00:00:00) while time zone support is active. RuntimeWarning)by usingdatetime.now()[ ] Add more asserts (maybe?)
Other Related Tickets & Documents (as needed)
#179
Implementation Details
[x] Created a factories.py file to generate new osprojects
[x] Tested that a newly created
osprojecthad the relevant fields[x] Ran
docker-compose run --rm app pytestand confirmed that tests passedNew Libraries/Dependancies Introduced (Fill out as needed)
N/A
If you have added libraries or other dependancies, please list them (and links to their repos) below:
requirements.txtAny new migration files added?
Did you add tests?
Code added or changed without test coverage or good reason for exemption won't be approved.
Yes, but could use feedback on these tests!
Did you add documentation?