Allow user to create hangouts from slack #943

gauravchl · 2018-08-17T15:31:36Z

Flow:

Slack user post message in slack channel
[DONE]Slack send this message to Codebuddies Meteor server.
[DONE]Meteor server read this message using Event subscription in real time https://api.slack.com/events-api
[DONE]Meteor server read the slack user's email and timezone who posted the above message using slack's web API
[DONE]Meteor server find the user in it's db whos email is same as the user who posted the message in slack. If user is found then it process to next step.
[DONE] Meteor server parse the message and read topic, start/end date and create hangout.
[DONE] On successful hangout creation Meteor server send back a message to slack channel.
[DONE] For now don't allow one user to create more than 5 hangouts per day from slack.

[DONE] Update response message, it should return hangout url like:

Hangout created successfully for 25 minutes, starting from Mon Sep. 3rd 2018. 5:00 pm Asia/Kolkota. 
 Go to https://codebuddies.org/hangout/Tu84XrgG8kzTMxsNy to edit or join the hangout.

Links:

Screencast: https://www.youtube.com/watch?v=2u64CBcBYSA
Issue: Schedule a hangout from Slack directly #937

https://api.slack.com/events-api

sebbel · 2018-08-18T15:33:15Z

server/routes.js

@@ -1,18 +1,24 @@
-var bodyParser = require('body-parser');
+var bodyParser = require("body-parser");
+import webhooks from "/server/slack/webhooks.js";


eslint problems? ping @distalx

@sebbel It's coming from my Prettier config. Will revert and disable for this project.

sebbel · 2018-08-18T15:34:49Z

server/routes.js

+    result
+  ) {
+    if (err) {
+      res.statusCode = 404;


404 is reserved for page not found. not sure, but I think for a server side error, we should use 500

sebbel · 2018-08-18T15:35:21Z

server/slack/webhooks.js

+    const { slackAppToken } = Meteor.settings;
+
+    if (!token || token !== slackAppToken) {
+      res.statusCode = 404;


sebbel · 2018-08-18T15:35:25Z

server/slack/webhooks.js

+      webhooks.processEvent(event);
+      return;
+    }
+    res.statusCode = 404;


sebbel · 2018-08-18T15:35:54Z

server/slack/webhooks.js

+  processEvent(event) {
+    console.log("webhook.processEvent", event);
+    const { user: slackUserId, text, type, channel, ts } = event || {};
+    if (type !== "message") return;


eslint should throw here ping @distalx

@sebbel Do we use any style guide for codebuddies? I can't find any eslint config.

@sebbel What do you mean by eslint throwing here? Throwing an error?

@gauravchl We have https://docs.codebuddies.org/code-contribution/coding_style, and Prettier does automatically updates the code in the PR to be a certain style. Let me know if you need help with any of the remaining tasks!

@lpatmo Thanks Linda! I will tackle remaining tasks this weekend, i might need some help with setting up slack app on production env.

@gauravchl Thanks, sounds great! I will be working on CB too this weekend. Re: hosting -- were you thinking something like a DigitalOcean droplet? We should have funds still in our DigitalOcean account from the DO sponsorship. That's where we're hosting https://github.com/codebuddies/greetbot at the moment. (Not sure if it's possible to build on top of greetbot for the purposes of this integration.)

@lpatmo Cool! Re Hosting: Naah, it doesn't need any extra droplet or server. It will run directly inside Meteor server where codebuddies.org is running. Just need to add some new keys(slack app tokens) inside settings-production.json, i'll PM you. And then install the bot on codebuddies slack channel.

Ah, that makes sense. I can def. add keys to both settings-development.json (so we can test it out) and then to settings-production.json for the release.

gauravchl · 2018-08-19T06:58:50Z

@sebbel Thanks for the review!

…sed from bot

…m-slack

gauravchl · 2018-09-02T13:10:00Z

@lpatmo @sebbel
The bot(cb_jarvis) is ready: https://youtu.be/eDrZC0uv8hA

How to test on development machine

Start the app on your localhost
Install ngrok and run ngrok http 3000, this will allow your local host to accept incoming requests from slack API. copy the https url(ie: https://6b935d58.ngrok.io)
Send me your email and i will add you to slack app(cb_jarvis) and slack channel https://gauravchl.slack.com/ created for testing this bot.
Go to cb_jarvis's settings https://api.slack.com/apps/ACAB1TCTD/event-subscriptions and paste the copied ngrok url to Request URL field like: https://6b935d58.ngrok.io/webhook/slack , Click verify.
Go to https://gauravchl.slack.com/ and ping cb_jarvis. Try:

@cb_jarvis help 
@cb_jarvis list hangout 
@cb_jarvis create hangout, tomorrow at 5pm, Learn css 
Try different dates like: Friday at 2 pm
Note: It uses Chrono natural language date parser: https://github.com/wanasit/chrono

How to deploy to production

Install app to codebuddies slack channel
Set Request URL to https://codebuddies.org/webhook/slack
Copy oAuth token and set it to settings-production.json
Deploy it to production
Verify Request URL from slack app setting.
Test it!

lpatmo · 2018-09-03T05:49:00Z

https://www.youtube.com/watch?v=eDrZC0uv8hA&feature=youtu.be is super exciting. Thanks for recording the demo!

An idea/suggestion: After a hangout is successfully created, could the return message on Slack could contain the URL to the hangout that was just created? This way, the user could get to it to edit the details about the hangout, assuming they're logged into the site already.

So the message might say:
Hangout created successfully for 25 minutes, starting from Mon Sep. 3rd 2018. 5:00 pm Asia/Kolkota. Go to https://codebuddies.org/hangout/Tu84XrgG8kzTMxsNy to edit or join the hangout.

I'm assuming that the payload from the site could include the post ID that's created, of course. If the URL isn't possible, we could say something like:
... Go to https://codebuddies.org/hangout to find your hangout and edit it if necessary`

gauravchl · 2018-09-04T13:00:18Z

@lpatmo done 😎

lpatmo

👍 🎆 🔥

Setup slack's event subscription to read slack messages

5fb2045

https://api.slack.com/events-api

lpatmo added the Waiting For Review label Aug 17, 2018

sebbel reviewed Aug 18, 2018

View reviewed changes

gauravchl added 12 commits September 2, 2018 12:03

Send proper HTTP response status code

851f2ac

Use slack web API seprately from webhooks

59599c0

Add method to post message back to channel

2088ca3

Add message parser

c71831e

Prepare hangout data

8bc7ceb

Moving hangout creation logic out from Meteor method so it can be reu…

26729b0

…sed from bot

Finally create hangout

f13248d

Show upcoming hangout counts as well

ba096fd

Add dummy keys for slack API

bdeee1e

Merge remote-tracking branch 'origin/master' into feature/hangout-fro…

9f410d9

…m-slack

Remove slipped console.log

d05501e

Code cleanup

456a74e

gauravchl changed the title ~~WIP: Allow user to create hangouts from slack~~ Allow user to create hangouts from slack Sep 2, 2018

Send hangout url back to bot

e70f9e8

gauravchl added 3 commits September 4, 2018 19:03

Allow user to create hangout in date range

f52909e

Use timezone abbrivation

9827a3c

Don't allow users to create more than 5 hangouts per day

9bc6a65

lpatmo closed this Sep 5, 2018

lpatmo deleted the feature/hangout-from-slack branch September 5, 2018 16:12

lpatmo added [state] closed the issue is now closed, see comments for more information and removed Waiting For Review labels Sep 5, 2018

lpatmo restored the feature/hangout-from-slack branch September 5, 2018 16:14

lpatmo reopened this Sep 5, 2018

ghost assigned lpatmo Sep 5, 2018

ghost added the [state] in-progress this issue is currently being worked on label Sep 5, 2018

lpatmo added Waiting For Review [state] in-progress this issue is currently being worked on and removed [state] closed the issue is now closed, see comments for more information Waiting For Review labels Sep 5, 2018

Minor edits to text

32a590d

lpatmo approved these changes Sep 5, 2018

View reviewed changes

lpatmo merged commit fd6b20a into codebuddies:master Sep 5, 2018

ghost removed the [state] in-progress this issue is currently being worked on label Sep 5, 2018

lpatmo added the [state] closed the issue is now closed, see comments for more information label Sep 5, 2018

lpatmo mentioned this pull request Oct 2, 2018

Slack API: share a learning to CodeBuddies directly from Slack (@cb_jarvis) #990

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow user to create hangouts from slack #943

Allow user to create hangouts from slack #943

gauravchl commented Aug 17, 2018 •

edited

Loading

sebbel Aug 18, 2018

gauravchl Aug 19, 2018

sebbel Aug 18, 2018

gauravchl Aug 19, 2018

sebbel Aug 18, 2018

sebbel Aug 18, 2018

sebbel Aug 18, 2018

gauravchl Aug 19, 2018

lpatmo Aug 20, 2018

gauravchl Aug 28, 2018

lpatmo Aug 30, 2018

gauravchl Aug 31, 2018 •

edited

Loading

lpatmo Sep 1, 2018

gauravchl commented Aug 19, 2018

gauravchl commented Sep 2, 2018

lpatmo commented Sep 3, 2018

gauravchl commented Sep 4, 2018

lpatmo left a comment

Allow user to create hangouts from slack #943

Allow user to create hangouts from slack #943

Conversation

gauravchl commented Aug 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gauravchl Aug 31, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gauravchl commented Aug 19, 2018

gauravchl commented Sep 2, 2018

How to test on development machine

How to deploy to production

lpatmo commented Sep 3, 2018

gauravchl commented Sep 4, 2018

lpatmo left a comment

Choose a reason for hiding this comment

gauravchl commented Aug 17, 2018 •

edited

Loading

gauravchl Aug 31, 2018 •

edited

Loading