Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/330 corrupt ascii qr code #339

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Conversation

codebude
Copy link
Owner

@codebude codebude commented Nov 8, 2021

Summary

This PR fixes/implements the following bugs/features:

  • [Bug] In some cases AsciiQrCodes weren't rendered well (lines were missing)
  • [Feature] New parameter "drawQuietZones" (default: true) allows to suppress the white border (aka "quietzone") around the QR graphic

Closing issues

This closes #330

Empty lines were falsely removed. (I guess the author initially wanted to remove the whitespace around the QR code. I will add a flag to suppress whitespace in another commit.)
Added new parameter "drawQuietZones" which enables to suppress the drawing of the quietzones (white border) around the QR code graphic
@codebude codebude merged commit 25217a0 into master Nov 8, 2021
@codebude codebude deleted the bugfix/330-corrupt-ascii-qr-code branch November 12, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid / corrupted QR Code
1 participant