Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

# prepare project for Capstone review #5

Merged
merged 80 commits into from
Apr 29, 2020
Merged

# prepare project for Capstone review #5

merged 80 commits into from
Apr 29, 2020

Conversation

codecell
Copy link
Owner

@codecell codecell commented Apr 8, 2020

What does this PR do

  • This PR is for review by the capstone team

Project Linter

  • This Linter is meant for linting Javascript files
    Things Covered Here
  • Errors currently detectable by js-companion
    • variable naming errors
    • class naming errors
    • Extra or redundant spacing errors
    • Multiple declaration of classes in a file (class count) errors
    • Unused variables are detected
      Testing
  • You can test online using the Replit badge in the Readme
  • Test Locally: after cloning the project, youcan test as follows
  • bin/main.rb file.js to test just a file
  • bin/main.rb foldernameContainingJsFiles to test all files in a folder
    • bin/main.rb . to test All *.js files and Folders

@codecell
Add rubocop & stickler settings
36a4383
@codecell
Merge pull request #1 from codecell/chore/proj_setup
956a96f 
Add rubocop & stickler settings
@codecell
Add ability to locate Js-containing Folders supplied to terminal
038a1f2
@codecell
make recommended rubocop adjustments
7d38888
@codecell
Merge pull request #2 from codecell/feature/search_js_path
46bcfb2 
Feature/search js path
@codecell
Add ability to read javascript files and set the lines
deaf4f9
@codecell
Add test Js folder
ea9f550
@codecell
Add ability to check spacing Erros
4cfc545
@codecell
Add rubocop corrections
accb669
@codecell
Add ability to check Naming errors
e6a57ec
@codecell
Add ability to check count of classes defined
b2c1681
@codecell
Add ability to check count of classes inside one module
4cd2d8d
@codecell
Correct Error printing colors and message
08c4150
@codecell
implement rubocop corrections
2dd68e3
@codecell
fix closing curly brace spacing bug
c221a25
@codecell
Add ability to check proper class naming
93f35aa
@codecell
fix message printing bug
d464886
@codecell
remove redundant code
bde942c
@codecell
implement rubocop corrections
fb25d8a
@codecell
Add ability to check Unused Variables
e666973
@codecell
Implement rubocop corrections
ea836c0
@codecell
Add run on repl.it badge to README
c9d7519 
This pull request adds a `Run on Repl.it` badge to the `README`. This will allow users to easily run this repository in their browser, without having to set up an environment. You can learn more about Repl.it [here](https://repl.it).
@codecell
Merge pull request #4 from codecell/replit-readme
7cf1dae 
Add Replit badge to readme
@codecell
Add Project Documentations to Readme
58b689e
@codecell
merge project readme branch
e226933
@codecell
correct typographical errors in Readme
1cdaf87
@codecell
Add rspec tests for JsParser Class
9e6ee58
@codecell
Add Rspec tests for Variables NamingChecker module
57048af
@codecell
Add Rspec tests for classname & spacing checkers
ff4ae5e
@codecell
Add instructions for unit tests to Readme
5429a9d
codecell and others added 29 commits April 27, 2020 14:32
@codecell
change version of release to t
25d1b73
@dependabot
Update rake requirement from ~> 10.0 to ~> 13.0
c4193f3 
Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](ruby/rake@v10.5.0...v13.0.1)

Signed-off-by: dependabot[bot] <support@github.com>
@codecell
Commit added files
de14e4c
@codecell
Merge pull request #8 from codecell/dependabot/bundler/rake-tw-13.0
a8c861a 
Update rake requirement from ~> 10.0 to ~> 13.0
@codecell
Update gem version to 0.1.0
850a570
@codecell
commit changes
8fdc0c7
@codecell
Move executable to exe older
9250de0
@codecell
Add updated gemspec
e32f679
@codecell
Require Runtime dependencies in exe/jscop
97adfc1
@codecell
Require Runtime dependencies in exe/jscop
e0dfcbe
@codecell
implement rubocop corrections
dfc2f20
@codecell
update usage instructions in Readme
c41c592
@codecell
Update Unit testing instructions in Readme
c35cdc3
@codecell
Fix merge conflict in exe/jscop
1cb4e1a
@codecell
Merge pre_release branch
d82200e
@codecell
Remove Gem lock file
d2a6af5
@codecell
Increase version of Rake required
74c3aa2
@codecell
Add .travis.yml
fa96e22
@codecell
Update Dir search path in gemspec
9cc3d87
@codecell
commit rake release 0.1.3
4d7d129
@codecell
Make Linters escape commented lines
a9d43dc
@codecell
Update version to 0.1.4
6837b8a
@codecell
Add Travis Ci badge to Readme
6305caf
@codecell
Update Travis badge to development
c831c46
@codecell
Handle github Security alert on depencies
4382780
@codecell
Handle github Security alert on depencies
ec7456b
@codecell
Make rake version backward compatible
01d1a5d
@codecell
Fix es6 syntax False-Positive errors detection
73f6458
@codecell
Remove redundtant test.js file
460728e
@codecell codecell merged commit 26d6c0a into master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codecell