fix references to support objects when using DI #1701
Conversation
|
Thank you! I also wanted to use Proxy for that but was not so smart to implement in a correct way |
|
Concerning the broken tests for webdriver, this seems to be due to an upgrade to latest chrome in the selenium standalone images. Therefor I currently have the docker images fixed to |
|
Sure, it's nothing to do with this PR. If you know how to fix the builds, could you please update .travis.yml and send a patch? |
some change to how the support objects are initialized removed the original reference to the support object and replaced it a "cloned" object. However, since Object.assign was used, not all properties have been copied and especially the original reference was lost. This implementation uses a proxy object to load the injected modules on demand and returns the original reference to the module. This should fix all usages of support objects, where the type is not a plain object.
|
The day has come. I'm merging! |
|
@johnyb your implementation broke recursive loading of support objects. Proxy was good but still, we need to initialize objects and then use Object.assign. In a new implementation https://github.com/Codeception/CodeceptJS/blob/codecept-221-release/lib/container.js#L213
|
|
Very good, thanks! |
some change to how the support objects are initialized removed the original
reference to the support object and replaced it a "cloned" object. However,
since Object.assign was used, not all properties have been copied and especially
the original reference was lost.
This implementation uses a proxy object to load the injected modules on demand
and returns the original reference to the module. This should fix all usages
of support objects, where the type is not a plain object.
Fixes: #1679