Skip to content

fix: dynamic config applied for multiple helpers #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

VikalpP
Copy link
Collaborator

@VikalpP VikalpP commented Jun 28, 2019

type: bug

What was the exact problem:
When dynamic config was set on default to picking helper[0]. At that time for multiple helpers, to apply config for the first helper ( helper[0] ), it was using an array of helpers as name to find helpers[name].

In short,

   if (name === '0') { // first helper
      name = Object.keys(helpers);
     // Now, typeof name is Array.
   }
   const helper = helpers[name];  // here, you can't use array to get particular helper

resolve #1742

@VikalpP VikalpP changed the title bug: fix dynamic config applied for multiple helpers fix: dynamic config applied for multiple helpers Jun 28, 2019
@VikalpP
Copy link
Collaborator Author

VikalpP commented Jun 28, 2019

@DavertMik Can you please review this and merge.
It's a dependency for PR #1733.

@DavertMik
Copy link
Contributor

Wow, thanks!

@DavertMik DavertMik merged commit 9ef3b3b into codeceptjs:master Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: dynamicConfig doesn't work for multiple Helpers
2 participants