Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): stepByStepReport unique report folder #1744

Merged
merged 1 commit into from
Jun 30, 2019
Merged

fix(plugin): stepByStepReport unique report folder #1744

merged 1 commit into from
Jun 30, 2019

Conversation

chimurai
Copy link
Contributor

@chimurai chimurai commented Jun 28, 2019

Currently the generated report folder names collide when tests have similar titles.
For example when you have test titles which start with "As a customer I want to..."

Different tests will end up being reported in same folder:
<dir>/record_As_a_customer_I_want_1561724771/index.html

With this fix a md5 hash is generated to avoid collisions in the reporting folders.
To calculate the md5 hash, test.file and test.title is used, just in case duplicate titles exist in a project.

After fix:
<dir>/record_d43336466a7e65faf417d9ea70b3df70/index.html

@DavertMik
Copy link
Contributor

Thanks!

@DavertMik DavertMik merged commit 187ab4a into codeceptjs:master Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants