fix: puppeteer basic auth fix #2178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-bartholomew
commented
Jan 31, 2020
| @@ -22,7 +22,7 @@ describe('Puppeteer - BasicAuth', () => { | |||
| global.codecept_dir = path.join(__dirname, '/../data'); | |||
|
|
|||
| I = new Puppeteer({ | |||
| url: 'http://localhost:8000', | |||
| url: siteUrl, | |||
There was a problem hiding this comment.
small fix for running tests (locally at least). I found that when running docker-compose run --rm test-helpers test/helper/Puppeteer_test.js that using localhost would error out with Error: net::ERR_CONNECTION_REFUSED at http://localhost:8000/basic_auth
ian-bartholomew
changed the title
Vorobeyko
suggested changes
Feb 2, 2020
|
Clones added
============
- test/helper/Puppeteer_test.js 2
See the complete overview on Codacy |
Vorobeyko
approved these changes
Feb 4, 2020
kobenguyent
approved these changes
Feb 4, 2020
|
Thank you! |
kobenguyent
added a commit
that referenced
this pull request
Feb 6, 2020
we have #2178 to fix puppeteer helper, so this patch will be applied in Playwright as well.
DavertMik
added a commit
that referenced
this pull request
Feb 11, 2020
* udpated changelog * initial Playwright implementation * (fix): add wait for actions call * (fix): more failed webapi tests * (test): trigger playwright tests on CI * (lint): please hound ^^ * (fix): remove wrongly use .only * (fix): setCookie method to parse param as array * (fix): change to setCookies * (fix): tabs tests * (fix): please hound * (fix): remove unused console.log * updated Playwright to make all tests pass * updated playwright tests to start a server * upated server start * Create playwright.md * (fix): update based on comments * add playwright option to init cmd * add option to show browser when initialising * (fix): basic auth we have #2178 to fix puppeteer helper, so this patch will be applied in Playwright as well. * enable describe('Playwright - BasicAuth') test * updated to playwright 0.10.0 * fixed tests, updated docs * updated docs * ported patch from #2181 Co-authored-by: Peter Nguyen Tr <peter.nguyentr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Noticed an issue with basic auth in the puppeteer helper when running multiple sessions. The authentication would be sent in the first scenario, but in subsequent scenarios it wouldn't get sent.
Applicable helpers:
Webdriver
Puppeteer
Nightmare
REST
Appium
Protractor
TestCafe
Description of this PR, which problem it solves
I found that the
isAuthenticatedboolean wasn't getting reset tofalse, so this adds that reset in_stopBrowser. This also adds anawaitto theauthenticatecall so that it doesn't setisAutheticatedbefore successfully authenticating.Type of change
Checklist:
npm run docs)npm run lint)npm test)