Skip to content

fix(command): generate test not respecting config #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

matheo
Copy link
Contributor

@matheo matheo commented Feb 12, 2020

Motivation/Description of the PR

codeceptjs generate:test is not detecting the suffix used in the project config.

I have this in my config:

tests: `./tests/**/*.spec.ts`

but the command still suggests _test.js.
This is solved with a small bugfix in the pattern line.

Type of change

  • Breaking changes
  • New functionality
  • Bug fix
  • Documentation changes/updates
  • Hot fix
  • Markdown files fix - not related to source code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@matheo
Copy link
Contributor Author

matheo commented Feb 12, 2020

@DavertMik @peterngtr can we respect the casing of the feature to be tested too?

42: (answers.feature).replace(' ', '_').toLowerCase() + defaultExt

or that's non-negotiable?
our company is using tests/UPPERCASED-TEAM/forgot-password.spec.ts

@DavertMik
Copy link
Contributor

can we respect the casing of the feature to be tested too?

Sure, we can! Please send PR!

@DavertMik DavertMik merged commit b9d20a8 into codeceptjs:master Feb 13, 2020
@matheo matheo deleted the bugfix-gen-test branch February 15, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants