Adding code to fix force click and ignore HTTPS errors in playwright #2566
Conversation
There was type here rectified it and it should be finw
There was a problem hiding this comment.
Our CI says that tests are failing for this PR.
Tests are failing on Playwright - so this is related to this PR.
There are 2 options, you either fix tests by yourself (we have contributing guide with details on tests) or you wait for me - I will work on the next release and this PR later this week.
lib/helper/Playwright.js
Outdated
| @@ -542,7 +543,7 @@ class Playwright extends Helper { | |||
| this.browser.on('targetchanged', (target) => { | |||
| this.debugSection('Url', target.url()); | |||
| }); | |||
| this.browserContext = await this.browser.newContext({ acceptDownloads: true, ...this.options.emulate }); | |||
| this.browserContext = await this.browser.newContext({ ignoreHTTPSErrors :this.options.ignoreHTTPSErrors,acceptDownloads: true, ...this.options.emulate });//Adding the HTTPSError ignore in the context so that we can ignore those errors | |||
There was a problem hiding this comment.
| this.browserContext = await this.browser.newContext({ ignoreHTTPSErrors :this.options.ignoreHTTPSErrors,acceptDownloads: true, ...this.options.emulate });//Adding the HTTPSError ignore in the context so that we can ignore those errors | |
| this.browserContext = await this.browser.newContext({ ignoreHTTPSErrors: this.options.ignoreHTTPSErrors,acceptDownloads: true, ...this.options.emulate });//Adding the HTTPSError ignore in the context so that we can ignore those errors |
There was a problem hiding this comment.
please fix formatting issues like this one - npm run lint-fix
There was a problem hiding this comment.
Is it for me ??
There was a problem hiding this comment.
@DavertMik I have committed the change requested
Adding this suggestion as it fixed the formatting Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>
|
Thank you! |
|
Hi guys, I think the page https://codecept.io/helpers/Playwright/#configuration is not up to date because the new |
|
@lepapareil I've created #3456, it covers also docs. |
Motivation/Description of the PR
I am exploring playwright as an option in my organization and SSL certificate errors plus forceClick fix was one of the functions that we needed to fix so that we could proceed further
Description of this PR, which problem it solves
This pull request resolves both the issues. Note the description of playwright configuration has to be updated to include ignoreHTTPSErrors
Resolves [Playwright] ignoreHTTPSErrors option for Webkit #2569
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs) (Don't know about this but I added comments)npm run lint)npm test) Yes they passed only for file system it failed but the contents seemed similar