fix: Fix actor type #2616
Merged
fix: Fix actor type #2616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According documentation (https://codecept.io/pageobjects/#dependency-injection) actor can be extended with function that can have any arguments. Therefore type definition should allow function with any arguments and not only functions without arguments.
Vorobeyko
approved these changes
Oct 9, 2020
kobenguyent
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
According documentation (https://codecept.io/pageobjects/#dependency-injection) actor can be extended with function that can have any arguments. But the present type definition (
() => void) allows only functions without arguments.This bug fix changes type definition in order to allow the use of functions with any number of any arguments.
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)