Skip to content

Adding the code to connect to sauce labs using a sauce tunnel when testing an app #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

gurjeetbains
Copy link
Contributor

…sting an app

Motivation/Description of the PR

  • Description of this PR, which problem it solves
  • This PR fixes the problem if some one has to connect to sauce labs via the tunnel to test the app (Android & IOS)
  • Resolves #issueId (if applicable).

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • [*] Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • puppeteerCoverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • wdio

Type of change

  • 🔥 Breaking changes
  • [*] 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@Arhell Arhell requested a review from DavertMik March 7, 2021 08:23
@DavertMik
Copy link
Contributor

@gurjeetbains please mention this in helper's docs and I'm merging

@gurjeetbains
Copy link
Contributor Author

@gurjeetbains please mention this in helper's docs and I'm merging

@DavertMik Should I raise a new PR and where should I update in the repo so that it updates in site as well. I have to do for playwright docs as well

@DavertMik
Copy link
Contributor

No, just add a few lines in a docblock section of Appium.js where we have confguration docs:

https://github.com/codeceptjs/CodeceptJS/blob/3.x/lib/helper/Appium.js#L43

And example configuration with a tunnel is also nice to have here:

https://github.com/codeceptjs/CodeceptJS/blob/3.x/lib/helper/Appium.js#L111

@DavertMik
Copy link
Contributor

@gurjeetbains I'm merging but please raise new PR for documentation

@DavertMik DavertMik merged commit f061466 into codeceptjs:3.x Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants