Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React Locator Support to Playwright #2912

Merged
merged 1 commit into from Aug 2, 2021
Merged

Add React Locator Support to Playwright #2912

merged 1 commit into from Aug 2, 2021

Conversation

AAAstorga
Copy link
Contributor

Motivation/Description of the PR

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • [ X] Playwright

Type of change

  • 馃敟 Breaking changes
  • [X ] 馃殌 New functionality
  • 馃悰 Bug fix
  • 馃搵 Documentation changes/updates
  • 鈾笍 Hot fix
  • 馃敤 Markdown files fix - not related to source code
  • 馃拝 Polish code

Checklist:

  • [X ] Tests have been added
  • [X ] Documentation has been added (Run npm run docs)
  • [X ] Lint checking (Run npm run lint)
  • [ X] Local tests are passed (Run npm test)

@Arhell Arhell requested a review from DavertMik June 5, 2021 06:44
@nikocanvacom nikocanvacom mentioned this pull request Jun 21, 2021
Closed
@DavertMik
Copy link
Contributor

Thank you, looks great!

@DavertMik DavertMik merged commit ff1edce into codeceptjs:3.x Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown engine "react" error using react selectors
4 participants
@AAAstorga @DavertMik @Arhell @auastorg