Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where cucumberJsonReporter not working with fakerTransform plugin #2942

Merged
merged 1 commit into from Aug 2, 2021

Conversation

ilangv
Copy link
Contributor

@ilangv ilangv commented Jun 30, 2021

Motivation/Description of the PR

This PR fixes issue where cucumberJsonReporter plugin fails to generate report when Scenario Outline uses fakerTransform plugin .

The root cause is that fakerTransform transform function updates all the steps and suite object but the underlying gherkin feature still has Examples with the faker mustache strings.

Replacing those cells with faker transformed value resolves the issue.

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • puppeteerCoverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • wdio

Type of change

  • 馃敟 Breaking changes
  • 馃殌 New functionality
  • 馃悰 Bug fix
  • 馃搵 Documentation changes/updates
  • 鈾笍 Hot fix
  • 馃敤 Markdown files fix - not related to source code
  • 馃拝 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@DavertMik
Copy link
Contributor

Thank you for your deep investigation and this fix!

@DavertMik DavertMik merged commit bd921be into codeceptjs:3.x Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants