Skip to content

Playwright I.haveRequestHeaders should affect all the tabs #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 25, 2021
Merged

Playwright I.haveRequestHeaders should affect all the tabs #3049

merged 4 commits into from
Sep 25, 2021

Conversation

jancorvus
Copy link
Contributor

Motivation/Description of the PR

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@jancorvus jancorvus changed the title Fix/playwright have request headers many tabs/3048 Playwright I.haveRequestHeaders affects only the first opened tab Sep 17, 2021
@jancorvus jancorvus changed the title Playwright I.haveRequestHeaders affects only the first opened tab Playwright I.haveRequestHeaders should affect all the tabs Sep 17, 2021
@DavertMik
Copy link
Contributor

Makes sense, thank you

@DavertMik DavertMik merged commit b4f7061 into codeceptjs:3.x Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playwright I.haveRequestHeaders affects only the first opened tab
3 participants
@jancorvus @DavertMik @Arhell