Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2889): return always the same error contract from simplifyTest #3168

Merged
merged 1 commit into from Jan 8, 2022

Conversation

andremoah
Copy link
Contributor

@andremoah andremoah commented Dec 9, 2021

Motivation/Description of the PR

Currently using patch-package with this fix on version 3.0.7 and been testing since then. With the complexity of the core api of codeceptjs, I could not find a way to replicate the error by sending an invalid object with inspect and cliMessage functions on it like shown in the reported issue. I would be glad to add some tests if someone could point me on how to build these tests to track the exact problem.

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 馃敟 Breaking changes
  • 馃殌 New functionality
  • 馃悰 Bug fix
  • 馃搵 Documentation changes/updates
  • 鈾笍 Hot fix
  • 馃敤 Markdown files fix - not related to source code
  • 馃拝 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@DavertMik
Copy link
Contributor

Thanks! I didn't get if that actually fixed the problem but this refactoring makes sense

@DavertMik DavertMik merged commit ad14258 into codeceptjs:3.x Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect BDD Parallel execution background fail/success
4 participants