Fix highlight element js handle context problem #3779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- evalute returns a promise and the try-catch does not handle rejected promise exception correctly. Not sure if it is realy necessary to print the exception via console.error
- so the highlighting also works for elements in frames and shoulg prevent throwing promise rection exception when calling evaluate method of the passed context
Arhell
approved these changes
Jul 27, 2023
kobenguyent
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
When elements in a frame were located and should be highlighted an Unexpected promise rejection terminates the test. So first step to fix it was, to add an .catch on the evaluate method because a promise is returned and the Promise Rejection was not handled by the try-catch block.
The second step was to fix the root of the problem which - in my optipn - was the context passed to highlightElement function. I changed it to _getContext() and so my tests run without a problem and elements in frames were highlighted correctly.
I applied the same changes for playwright, but I could test it only with puppeteer in my project. I am not sure if it is an issue for the WebDriver helper, too.
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)