Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css to xpath backward compatibility #4141

Merged
merged 4 commits into from Jan 21, 2024
Merged

fix: css to xpath backward compatibility #4141

merged 4 commits into from Jan 21, 2024

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Jan 16, 2024

Motivation/Description of the PR

Soooo, another try, I hope we could resolve this this time. I could not think of any better solution right now but this hybrid approach would be a cheap and fast way right now.

We will check the locator and load either the old one which is being used until 3.5.8 css-to-xpath or the new one csstoxpath.

Test build: https://www.npmjs.com/package/codeceptjs/v/3.5.12-beta.3

Type of change

  • 馃悰 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent merged commit ad1bb15 into 3.x Jan 21, 2024
14 checks passed
@kobenguyent kobenguyent deleted the css-2-xpath branch January 21, 2024 07:11
@kobenguyent kobenguyent mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selector regression with upgrade from 3.5.8 to 3.5.11
2 participants