New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(puppeteer): network traffics manipulation #4263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no plural for traffic and share
so better to rename "networkTraffics" => network
"shares" => "share"
but maybe we don't need this share?
it is already shared
@@ -0,0 +1,123 @@ | |||
const assert = require('assert'); | |||
const { isInTraffic, createAdvancedTestResults, getTrafficDump } = require('../utils'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need shares
folder for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are the same pieces of code that appeared in 3 helpers. So I wanna move them to a shared folder which is better than copy/paste the same code in 3 helpers.
Motivation/Description of the PR
🛩️ Features
startRecordingTraffic
grabRecordedNetworkTraffics
flushNetworkTraffics
stopRecordingTraffic
seeTraffic
dontSeeTraffic
Examples:
Applicable helpers:
Type of change
Checklist:
npm run docs
)npm run lint
)npm test
)