[WIP] Playwright: I.waitForText() causes unexpected delay equal to waitForTimeout value at the end of test suite

[Copilot]

Fixed the issue where I.waitForText() causes an unexpected delay equal to waitForTimeout value at the end of test suite in Playwright helper.

Solution Implemented

• Explored repository structure and understood the codebase
• Identified the problematic waitForText method in lib/helper/Playwright.js
• Found the root cause: promiseRetry with aggressive retry settings continues running in background
• Created focused unit test to reproduce the issue
• Implemented minimal fix to prevent background promise execution
• Tested the fix to ensure it resolves the delay issue
• Verified no regression in existing functionality (all 344 unit tests passing)
• Committed and pushed the fix

Root Cause

The issue was in the waitForText method which uses Promise.race with multiple strategies, including a promiseRetry with extremely aggressive settings:

• retries: 1000
• minTimeout: 500ms
• maxTimeout: 500ms
• factor: 1

This meant up to 1000 × 500ms = 500 seconds (8+ minutes) of background execution even after the main promise resolved.

Solution

Two-part fix implemented:

1. Added a stop flag: Introduced shouldStop boolean to signal the promiseRetry to stop when the race resolves
2. Reduced aggressive retry settings: Changed from {retries: 1000, minTimeout: 500, maxTimeout: 500, factor: 1} to {retries: 10, minTimeout: 100, maxTimeout: 500, factor: 1.5} which provides reasonable retry behavior with exponential backoff

The fix is minimal, surgical, and maintains all existing functionality while eliminating the problematic delay.

Fixes #4999.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

@kobenguyent 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.