[WIP] 3.7.3 I.seeResponseContainsJson not working

[Copilot]

Fixed the issue with I.seeResponseContainsJson() not working correctly in version 3.7.3. The problem was in the _assertContains method when dealing with arrays.

Root Cause:

• The _assertContains method was treating arrays as objects and doing index-by-index comparison instead of checking if each expected array element had a corresponding match in the actual array
• This caused it to only check the first element in arrays rather than searching through all elements

Solution:

• Modified the _assertContains method to properly handle array matching by detecting when expected values are arrays and implementing proper element-by-element matching logic
• When the expected value is an array, the method now searches through all elements in the actual array to find matches for each expected element
• Improved error messages to be more descriptive when matches are not found

Changes Made:

• Enhanced _assertContains method in lib/helper/JSONResponse.js to handle arrays correctly
• Updated test expectations in test/helper/JSONResponse_test.js to match new error messages
• Fixed unrelated test issue with callback test using wrong parameter (assert vs expect)
• Validated fix with comprehensive tests covering various scenarios
• Ensured all existing tests still pass

Validation:

• All unit tests pass (344/344)
• JSONResponse-specific tests pass (16/16)
• Created comprehensive test scenarios to verify the fix works for:
  • Array properties within objects (finding elements by position)
  • Response data that is itself an array
  • Multiple element matching
  • Proper failure cases with clear error messages

The fix now correctly searches through all array elements for matches instead of stopping at the first element, restoring the behavior that worked in version 3.6.5.

Fixes #4993.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.