fix: TestCafe grabAttributeFrom method not works #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine, but test failed |
|
Don't understand, why travis build for TestCafe fails every time with catched error from previous test And why circle-ci with webdriver fails |
|
Skipped some failing tests for TestCafe. But somewhy Webdriverio tests fails in Circle CI, does not know why. |
|
Looks like we have a problem with test. Cause if some test in test suite thows error (and catches it), then all next tests fails |
|
webdriverio v5.16.12 was released between first (passed) and second (failed) circle CI builds. |
DavertMik
previously approved these changes
Dec 6, 2019
elukoyanov
force-pushed
the
fix/testcafe-grabattributefrom
branch
from
e3ed1aa
to
ea9de4d
Compare
|
Clones added
============
- test/helper/webapi.js 4
See the complete overview on Codacy |
DavertMik
approved these changes
Dec 6, 2019
Vorobeyko
approved these changes
Dec 8, 2019
Vorobeyko
added a commit
that referenced
this pull request
Jan 17, 2020
* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * try to shorten the test execution time * Update package.json * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>
DavertMik
added a commit
that referenced
this pull request
Jan 22, 2020
* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * add I.say() to allure * Remove I say Co-Authored-By: Michael Bodnarchuk <DavertMik@users.noreply.github.com> Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com> Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>
DavertMik
pushed a commit
that referenced
this pull request
Jan 22, 2020
* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * fix the ambiguous description * CR fix Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>
DavertMik
pushed a commit
that referenced
this pull request
Jan 23, 2020
…#2140) * Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * some improvements * improve the way to get uuid * move private func to the end * mocha update is not here Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>
DavertMik
pushed a commit
that referenced
this pull request
Jan 23, 2020
* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * (fix): no custom output folder is created with run-worker * CR fix * verify the output folder is created Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Webdriver
Puppeteer
Nightmare
REST
Appium
Protractor
TestCafe
Description of this PR, which problem it solves
grabAttributeFrom()method not returning the attribute valueA link to the corresponding issue (if applicable).
https://stackoverflow.com/questions/59133688/grabattributefrom-method-not-returning-the-attribute-value
Type of change
Checklist:
npm run docs)npm run lint)npm test)