(feat): add I say event to allure #2146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `console.print()` does not exists 😄
* check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces
* docs: remove prepending line in JSDoc generator * definitions: update generated types
* fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips
* #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3
Vorobeyko
previously approved these changes
Jan 17, 2020
|
@Vorobeyko @peterngtr I can review and retest if you grant write access. |
|
@peterngtr is this problem for allure only? Or there are problem, which fix all other helpers |
DavertMik
requested changes
Jan 18, 2020
I think whatever helper is used would be fine with adding this in allure plugin directly. |
Co-Authored-By: Michael Bodnarchuk <DavertMik@users.noreply.github.com>
DavertMik
approved these changes
Jan 18, 2020
Please do more reviews and become part of our core team to get write access. Meanwhile, you can always test changes from fork's banrch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Resolves #2104
I think the timestamps could be left as 0s or any suggestion on this would be nice
Type of change