File system extended #2034

aefluke · 2019-11-18T08:20:28Z

FileSystem Extension

Applicable helpers:

Webdriver
Puppeteer
Nightmare
REST
Appium
Protractor
TestCafe
For a project I've been working with I need to download and assert the downloaded file but filenames are partially unique, so I only know a part of the file I want to see/assert. I've added support for asserting that any file exists including the given text.
Also for this issue I needed get the filenames in current directory, I've exploited the getFileNames() function for further use.

Type of change

Checklist:

Tests have been added
Documentation has been added (Run robo docs)
Lint checking (Run npm run lint)
Local tests are passed (Run npm test)

lib/helper/FileSystem.js

kobenguyent · 2019-11-18T11:15:02Z

@aefluke please rebase with master, I believe your branch is not updated since. That somehow made CI failed.

DavertMik

Sorry, this fails on Node 8.
See Travis CI build

aefluke · 2019-11-19T06:11:17Z

Do you have any idea why circleci:docker job fails?

kobenguyent · 2019-11-19T06:48:35Z

Please rebase with master Branch of codeceptjs. Your .circleci config is not updated.

…eptJS; branch 'master' of https://github.com/Codeception/CodeceptJS into fileSystemExtended

kobenguyent

LGTM!

lib/helper/FileSystem.js

…ileSystemExtended

…eptJS into fileSystemExtended

DavertMik

The code looks good but descriptions are not really clear. I tried to improve them but the best we can do is to add some code examples on how those methods should be used

lib/helper/FileSystem.js

aefluke · 2019-12-03T05:49:59Z

Hello @DavertMik,
Examples are added, doc comments are updated as suggested.

kobenguyent · 2019-12-06T15:04:56Z

Thanks @aefluke !

* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * try to shorten the test execution time * Update package.json * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>

* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * add I.say() to allure * Remove I say Co-Authored-By: Michael Bodnarchuk <DavertMik@users.noreply.github.com> Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com> Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>

* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * fix the ambiguous description * CR fix Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>

…#2140) * Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * some improvements * improve the way to get uuid * move private func to the end * mocha update is not here Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>

* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * (fix): no custom output folder is created with run-worker * CR fix * verify the output folder is created Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>

aefluke added 2 commits November 18, 2019 10:02

check file exists with given substring

8ca3f1d

tests are added

5d5ccae

hound bot reviewed Nov 18, 2019

View reviewed changes

lib/helper/FileSystem.js Outdated Show resolved Hide resolved

lib/helper/FileSystem.js Outdated Show resolved Hide resolved

lib/helper/FileSystem.js Outdated Show resolved Hide resolved

aefluke added 2 commits November 18, 2019 11:34

deleted trailing-space

85b6ec2

removed spaces

55a5bf1

kobenguyent reviewed Nov 18, 2019

View reviewed changes

lib/helper/FileSystem.js Outdated Show resolved Hide resolved

DavertMik requested changes Nov 18, 2019

View reviewed changes

aefluke added 2 commits November 19, 2019 08:31

compatibility for node 8

2331f20

assertion message fixed

14f3b27

aefluke requested a review from DavertMik November 19, 2019 06:10

aefluke requested a review from kobenguyent November 19, 2019 06:32

Merge branch 'fileSystemExtended' of https://github.com/aefluke/Codec…

4157e61

…eptJS; branch 'master' of https://github.com/Codeception/CodeceptJS into fileSystemExtended

kobenguyent approved these changes Nov 19, 2019

View reviewed changes

kobenguyent added file helper ready for merging labels Nov 19, 2019

Vorobeyko suggested changes Nov 19, 2019

View reviewed changes

lib/helper/FileSystem.js Outdated Show resolved Hide resolved

kobenguyent removed the ready for merging label Nov 19, 2019

aefluke requested a review from Vorobeyko November 19, 2019 13:33

aefluke added 9 commits November 19, 2019 21:36

Merge branch 'master' of https://github.com/aefluke/CodeceptJS into f…

b252772

…ileSystemExtended

check file exists with given substring

b783e52

tests are added

666065b

deleted trailing-space

a933075

removed spaces

099f53c

compatibility for node 8

a4fd101

assertion message fixed

07a0517

Merge branch 'fileSystemExtended' of https://github.com/aefluke/Codec…

acfcbe1

…eptJS into fileSystemExtended

get changed into grab

968cb21

kobenguyent added the ready for merging label Nov 21, 2019

Vorobeyko approved these changes Nov 22, 2019

View reviewed changes

DavertMik approved these changes Nov 22, 2019

View reviewed changes

DavertMik requested changes Nov 22, 2019

View reviewed changes

lib/helper/FileSystem.js Outdated Show resolved Hide resolved

lib/helper/FileSystem.js Outdated Show resolved Hide resolved

DavertMik removed the ready for merging label Nov 22, 2019

Examples added

f84deca

hound bot reviewed Nov 24, 2019

View reviewed changes

lib/helper/FileSystem.js Outdated Show resolved Hide resolved

lib/helper/FileSystem.js Show resolved Hide resolved

lib/helper/FileSystem.js Show resolved Hide resolved

lib/helper/FileSystem.js Outdated Show resolved Hide resolved

trailing spaces

8ee0027

aefluke requested a review from DavertMik November 24, 2019 20:09

Vorobeyko approved these changes Nov 24, 2019

View reviewed changes

DavertMik approved these changes Dec 6, 2019

View reviewed changes

kobenguyent merged commit 6f487e0 into codeceptjs:master Dec 6, 2019

aefluke deleted the fileSystemExtended branch February 12, 2020 11:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

File system extended #2034

File system extended #2034

Uh oh!

aefluke commented Nov 18, 2019 •

edited by Vorobeyko

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kobenguyent commented Nov 18, 2019

Uh oh!

DavertMik left a comment

Uh oh!

aefluke commented Nov 19, 2019

Uh oh!

kobenguyent commented Nov 19, 2019

Uh oh!

kobenguyent left a comment

Uh oh!

Uh oh!

DavertMik left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aefluke commented Dec 3, 2019

Uh oh!

kobenguyent commented Dec 6, 2019

Uh oh!

Uh oh!

Uh oh!

File system extended #2034

File system extended #2034

Uh oh!

Conversation

aefluke commented Nov 18, 2019 • edited by Vorobeyko Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

FileSystem Extension

Type of change

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kobenguyent commented Nov 18, 2019

Uh oh!

DavertMik left a comment

Choose a reason for hiding this comment

Uh oh!

aefluke commented Nov 19, 2019

Uh oh!

kobenguyent commented Nov 19, 2019

Uh oh!

kobenguyent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DavertMik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aefluke commented Dec 3, 2019

Uh oh!

kobenguyent commented Dec 6, 2019

Uh oh!

Uh oh!

aefluke commented Nov 18, 2019 •

edited by Vorobeyko

Loading