Fix file loading API and WebSocket connection issues #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix POST /api/file to read from request body (path parameter) - Add backward compatibility for existing file API usage - Fix WebSocket URL construction to use ws:/wss: protocol - Add JSON body parser to file endpoint - Maintain streaming for legacy requests while adding JSON response for frontend Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
kobenguyent
September 1, 2025 11:35
|
🎉 This PR is included in version 1.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two critical issues preventing proper functionality of the CodeceptJS UI:
Issue 1: File Content Loading Fails with 400 Error
When clicking on a test file to view its content, the frontend was receiving a
400 Bad Requesterror:Root Cause: The frontend sends a POST request with JSON body
{ path: test.file, line: test.line }, but the backend API expected the file path inreq.fileparameter instead ofreq.body.path.Solution:
/api/fileendpoint to read fromreq.body.pathfor new frontend requestsreq.fileparametersourcefield for frontend consumption while preserving file streaming for legacy usageIssue 2: WebSocket Connection Refused Error
Browser tests couldn't start due to WebSocket connection failures:
Root Cause: The frontend was constructing WebSocket URLs using
window.location.protocol(e.g.,http:), but WebSocket connections requirews:orwss:protocols.Solution:
src/main.jsto properly converthttp:→ws:andhttps:→wss:Key Changes
lib/api/get-file.js: Enhanced to support both JSON body requests and legacy parameter requestslib/api/index.js: Added JSON body parser to/api/fileendpointsrc/main.js: Fixed WebSocket URL protocol conversionTesting
These changes ensure that both test file content loading and WebSocket-based browser test execution work correctly.
Fixes #570.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.iohttps://storage.googleapis.com/chrome-for-testing-public/139.0.7258.154/linux64/chrome-headless-shell-linux64.zipnode install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.