Add DroneCI support #215
Merged
Add DroneCI support #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dblandin
reviewed
Aug 24, 2017
env/ci.go
Outdated
| @@ -27,8 +27,8 @@ func loadCIInfo() ci { | |||
| } | |||
| } | |||
|
|
|||
| var ciNameVars = []string{"CI_NAME", "APPVEYOR", "BUILDKITE", "CIRCLECI", "GITLAB_CI", "JENKINS_URL", "SEMAPHORE", "TDDIUM", "TRAVIS", "WERCKER"} | |||
| var ciNameVars = []string{"CI_NAME", "CI", "APPVEYOR", "BUILDKITE", "CIRCLECI", "GITLAB_CI", "JENKINS_URL", "SEMAPHORE", "TDDIUM", "TRAVIS", "WERCKER"} | |||
There was a problem hiding this comment.
I think the CI environment variable is set to true in other CI environments, like travis. Could we move this to the end of the list so that other, more specific environment variable names are attempted first?
`CI` env var is set to `true` in CI environments like travis, so it should be placed at the end of the list.
|
@dblandin Done, I've moved it to the end of the list. 👀 |
dblandin
approved these changes
Aug 24, 2017
|
Awesome! @dblandin thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: codeclimate/ruby-test-reporter#193 (comment)
We're using self-hosted open-sourced DroneCI. We filed a support ticket recently on missing DroneCI support (see details in codeclimate/ruby-test-reporter#193).
This PR updates test-reporter to support DroneCI-specific environment variables.
DroneCI environment variables: http://docs.drone.io/environment-reference/