Support clover path attribute on file nodes in XML report
#349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XML report generated by more recent versions of clover include the full path to the file within a `path` attribute. The `name` attribute in these reports contains just the filename without any directory structure. To support reading the source file, we'll need to reference this new attribute.
|
@dblandin this LGTM overall, do you know if the attribute |
|
I'm not sure which is why I added the fallback. |
|
@ale7714 For what it's worth, the fixture example included in this repo does not include the |
ale7714
approved these changes
Jul 31, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XML report generated by more recent versions of clover include the full path to the file within a
pathattribute. Thenameattribute in these reports contains just the filename without any directorystructure.
To support reading the source file, we'll need to reference this new attribute.