fix: handle trailing commas (#1470)

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
codecov · Jun 10, 2024 · feaf700 · feaf700
1 parent 7b6a727
commit feaf700
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -32568,7 +32568,9 @@ const buildUploadExec = () => buildExec_awaiter(void 0, void 0, void 0, function
     }
     if (files) {
         files.split(',').map((f) => f.trim()).forEach((f) => {
-            uploadExecArgs.push('-f', `${f}`);
+            if (f.length > 0) { // this handles trailing commas
+                uploadExecArgs.push('-f', `${f}`);
+            }
         });
     }
     if (flags) {

diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/buildExec.test.ts b/src/buildExec.test.ts
@@ -75,7 +75,7 @@ test('upload args', async () => {
     'exclude': 'node_modules/',
     'fail_ci_if_error': 'true',
     'file': 'coverage.xml',
-    'files': 'dir1/coverage.xml,dir2/coverage.xml',
+    'files': 'dir1/coverage.xml,dir2/coverage.xml,',
     'flags': 'test,test2',
     'git_service': 'github_enterprise',
     'handle_no_reports_found': 'true',

diff --git a/src/buildExec.ts b/src/buildExec.ts
@@ -311,7 +311,9 @@ const buildUploadExec = async (): Promise<{
   }
   if (files) {
     files.split(',').map((f) => f.trim()).forEach((f) => {
-      uploadExecArgs.push('-f', `${f}`);
+      if (f.length > 0) { // this handles trailing commas
+        uploadExecArgs.push('-f', `${f}`);
+      }
     });
   }
   if (flags) {