Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent org admins from being activated even without seat #609

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Jun 7, 2024

Updates isCurrentUserActivated resolver to no longer count admins as activated when they don't have a seat.

Closes https://github.com/codecov/internal-issues/issues/502

After this change, admins will see the following when trying to access a private repo when not activated:
Screenshot 2024-06-10 at 09 53 57

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review June 7, 2024 19:02
@spalmurray-codecov spalmurray-codecov requested a review from a team as a code owner June 7, 2024 19:02
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (4355328) to head (fbbd6ff).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         615      615           
  Lines       16370    16370           
=======================================
  Hits        14977    14977           
  Misses       1393     1393           
Flag Coverage Δ
unit 91.49% <100.00%> (ø)
unit-latest-uploader 91.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/owner/owner.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (4355328) to head (fbbd6ff).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         615      615           
  Lines       16370    16370           
=======================================
  Hits        14977    14977           
  Misses       1393     1393           
Flag Coverage Δ
unit 91.49% <100.00%> (ø)
unit-latest-uploader 91.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/owner/owner.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (4355328) to head (fbbd6ff).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #609   +/-   ##
===========================================
  Coverage   95.92000   95.92000           
===========================================
  Files           793        793           
  Lines         17688      17688           
===========================================
  Hits          16968      16968           
  Misses          720        720           
Flag Coverage Δ
unit 91.49% <100.00%> (ø)
unit-latest-uploader 91.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 65cc1f8 Jun 10, 2024
21 of 22 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-admins-enabled-without-seat branch June 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants