-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent org admins from being activated even without seat #609
fix: Prevent org admins from being activated even without seat #609
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #609 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 615 615
Lines 16370 16370
=======================================
Hits 14977 14977
Misses 1393 1393
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #609 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 615 615
Lines 16370 16370
=======================================
Hits 14977 14977
Misses 1393 1393
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
===========================================
Coverage 95.92000 95.92000
===========================================
Files 793 793
Lines 17688 17688
===========================================
Hits 16968 16968
Misses 720 720
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Updates
isCurrentUserActivated
resolver to no longer count admins as activated when they don't have a seat.Closes https://github.com/codecov/internal-issues/issues/502
After this change, admins will see the following when trying to access a private repo when not activated: