Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Suppress sentry validation errors #614

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

Purpose/Motivation

This closes https://github.com/codecov/internal-issues/issues/438

We will return None instead of raising a validation error if the repo is active. The front-end already checks if the tokens do not exist to conditionally render components.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (965f943) to head (938747f).

@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         620      620           
  Lines       16473    16473           
=======================================
  Hits        15077    15077           
  Misses       1396     1396           
Flag Coverage Δ
unit 91.52% <100.00%> (ø)
unit-latest-uploader 91.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nds/repository/interactors/get_repository_token.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov-public-qa bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (965f943) to head (938747f).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         620      620           
  Lines       16473    16473           
=======================================
  Hits        15077    15077           
  Misses       1396     1396           
Flag Coverage Δ
unit 91.52% <100.00%> (ø)
unit-latest-uploader 91.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nds/repository/interactors/get_repository_token.py 100.00% <100.00%> (ø)

Impacted file tree graph

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review June 12, 2024 17:37
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (965f943) to head (938747f).

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #614   +/-   ##
===========================================
  Coverage   95.94000   95.94000           
===========================================
  Files           798        798           
  Lines         17790      17790           
===========================================
  Hits          17069      17069           
  Misses          721        721           
Flag Coverage Δ
unit 91.52% <100.00%> (ø)
unit-latest-uploader 91.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 0bf9747 Jun 21, 2024
21 of 22 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/fix-sentry-errors branch June 21, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants