Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Self-hosted link on Login page.jsx #2527

Closed
wants to merge 1 commit into from

Conversation

jerrodcodecov
Copy link
Contributor

Update out of date "enterprise" landing page --> Dedicated Enterprise Cloud on the login page

Update out of date "enterprise" landing page --> Dedicated Enterprise Cloud
@codecov-staging
Copy link

codecov-staging bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2527   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         797      797           
  Lines       10279    10279           
  Branches     2584     2584           
=======================================
  Hits        10104    10104           
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/pages/LoginPage/LoginPage.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e975b...5e125e1. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5e975b) 98.29% compared to head (5e125e1) 98.29%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2527   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         797      797           
  Lines       10279    10279           
  Branches     2579     2565   -14     
=======================================
  Hits        10104    10104           
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/pages/LoginPage/LoginPage.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e975b...5e125e1. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 22, 2024

Codecov Report

Merging #2527 (5e125e1) into main (e5e975b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2527   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         797      797           
  Lines       10279    10279           
  Branches     2533     2535    +2     
=======================================
  Hits        10104    10104           
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/pages/LoginPage/LoginPage.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e975b...5e125e1. Read the comment docs.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5e975b) 98.30% compared to head (5e125e1) 98.30%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2527   +/-   ##
=====================================
  Coverage   98.30   98.30           
=====================================
  Files        797     797           
  Lines      10279   10279           
  Branches    2584    2579    -5     
=====================================
  Hits       10104   10104           
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
src/pages/LoginPage/LoginPage.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <ø> (ø)
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e975b...5e125e1. Read the comment docs.

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 5e125e1
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65ae948a40c46e0008497220
😎 Deploy Preview https://deploy-preview-2527--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nicholas-codecov
Copy link
Contributor

Instead of setting a static link in the in that location, we should update it here in useStaticNavLinks so that is updated across Gazebo rather then in this specific location.

@jerrodcodecov
Copy link
Contributor Author

@nicholas-codecov great call, it actually seems like there is a StaticNavLink for DedicatedEnterpriseCloud already

https://github.com/codecov/gazebo/blob/jerrodcodecov-patch-2/src/services/navigation/useNavLinks/useStaticNavLinks.js#L223

I'll instead look for all references to pageName: 'enterprise' and see if it makes sense to update globally and remove the enterprise StaticNavLink, else leave as self-hosted with a different link. Onwards

@nicholas-codecov
Copy link
Contributor

Closing in favour of #2949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants