feat: Move bundle tab trend dropdown #3019

nicholas-codecov · 2024-07-16T16:43:19Z

Description

This PR adjusts the trend dropdown on the bundles tab to be inline with the toggle chart button so that the user can still change the trend which applies to the assets table. Also included is a small tweak to remove passing an artificial date and instead pass null which the API will interpret as the first data point.

Notable Changes

Rework ToggleElement to allow element to be placed inline
Move TrendDropdown from BundleChart to BundleContent
Pass null for after instead of artificial date - the change to adjust the query to accept this was already done
Create/Update tests

Screenshots

…ith toggle button

codecov-qa · 2024-07-16T16:46:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (f45efbf) to head (57750fd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3019   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         910      910           
  Lines       13535    13535           
  Branches     3588     3588           
=======================================
  Hits        13313    13313           
  Misses        218      218           
  Partials        4        4

Files	Coverage Δ
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
...ndlesTab/BundleContent/BundleChart/BundleChart.tsx	`100.00% <ø> (ø)`
...ab/BundleContent/BundleChart/useBundleChartData.ts	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/BundleContent.tsx	`100.00% <ø> (ø)`
...epoPage/BundlesTab/BundleContent/ToggleElement.tsx	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/TrendDropdown.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleAssets.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleTrendData.tsx	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.68% <ø> (ø)`
Pages	`99.15% <100.00%> (ø)`
Services	`99.47% <ø> (ø)`
Shared	`99.69% <ø> (ø)`
UI	`94.28% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45efbf...57750fd. Read the comment docs.

codecov-public-qa · 2024-07-16T16:46:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (f45efbf) to head (57750fd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3019   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         910      910           
  Lines       13535    13535           
  Branches     3588     3664   +76     
=======================================
  Hits        13313    13313           
  Misses        218      218           
  Partials        4        4

Files	Coverage Δ
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
...ndlesTab/BundleContent/BundleChart/BundleChart.tsx	`100.00% <ø> (ø)`
...ab/BundleContent/BundleChart/useBundleChartData.ts	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/BundleContent.tsx	`100.00% <ø> (ø)`
...epoPage/BundlesTab/BundleContent/ToggleElement.tsx	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/TrendDropdown.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleAssets.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleTrendData.tsx	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.68% <ø> (ø)`
Pages	`99.15% <100.00%> (ø)`
Services	`99.47% <ø> (ø)`
Shared	`99.69% <ø> (ø)`
UI	`94.28% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45efbf...57750fd. Read the comment docs.

codecov-notifications · 2024-07-16T16:46:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3019   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         910      910           
  Lines       13535    13535           
  Branches     3659     3638   -21     
=======================================
  Hits        13313    13313           
  Misses        218      218           
  Partials        4        4

Files	Coverage Δ
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
...ndlesTab/BundleContent/BundleChart/BundleChart.tsx	`100.00% <ø> (ø)`
...ab/BundleContent/BundleChart/useBundleChartData.ts	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/BundleContent.tsx	`100.00% <ø> (ø)`
...epoPage/BundlesTab/BundleContent/ToggleElement.tsx	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/TrendDropdown.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleAssets.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleTrendData.tsx	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.68% <ø> (ø)`
Pages	`99.15% <100.00%> (ø)`
Services	`99.47% <ø> (ø)`
Shared	`99.69% <ø> (ø)`
UI	`94.28% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45efbf...57750fd. Read the comment docs.

codecov-staging · 2024-07-16T16:48:50Z

Bundle Report

Changes will increase total bundle size by 91 bytes ⬆️

Bundle name	Size	Change
gazebo-staging-array-push	6.07MB	91 bytes ⬆️

codecov · 2024-07-16T16:48:56Z

Bundle Report

Changes will increase total bundle size by 91 bytes ⬆️

Bundle name	Size	Change
gazebo-production-array-push	6.07MB	91 bytes ⬆️

codecov · 2024-07-16T16:50:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (f45efbf) to head (57750fd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##               main      #3019   +/-   ##
===========================================
  Coverage   98.35000   98.35000           
===========================================
  Files           910        910           
  Lines         13535      13535           
  Branches       3659       3664    +5     
===========================================
  Hits          13313      13313           
  Misses          218        218           
  Partials          4          4

Files	Coverage Δ
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
...ndlesTab/BundleContent/BundleChart/BundleChart.tsx	`100.00% <ø> (ø)`
...ab/BundleContent/BundleChart/useBundleChartData.ts	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/BundleContent.tsx	`100.00% <ø> (ø)`
...epoPage/BundlesTab/BundleContent/ToggleElement.tsx	`100.00% <100.00%> (ø)`
...epoPage/BundlesTab/BundleContent/TrendDropdown.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleAssets.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleTrendData.tsx	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.68% <ø> (ø)`
Pages	`99.15% <100.00%> (ø)`
Services	`99.47% <ø> (ø)`
Shared	`99.69% <ø> (ø)`
UI	`94.28% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45efbf...57750fd. Read the comment docs.

codecov-releaser · 2024-07-16T16:55:03Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`7bdc696`	Tue, 16 Jul 2024 16:55:02 GMT	Expired	Expired
`57750fd`	Wed, 17 Jul 2024 12:12:43 GMT	Cloud	Enterprise

ajay-sentry · 2024-07-16T21:46:51Z

src/pages/RepoPage/BundlesTab/BundleContent/ToggleElement.tsx

+          <span className="transition-transform duration-200">
+            <Icon size="md" variant="solid" name="chevronRight" />
+          </span>
+          {isHidden ? showElement : hideElement}


this is a little confusing, isHidden == true then show element?

I understand the intent, but maybe there's a way to modify the wording here a bit 🤔

ajay-sentry

1 comment, not blocking though

nicholas-codecov added 5 commits July 16, 2024 13:35

move trend dropdown

3059e84

remove trend dropdown from bundle chart

01facab

move and update toggle element to allow element to be placed inline w…

f18cd48

…ith toggle button

pass TrendDropdown to ToggleElement component

7f47713

pass null instead of date for after var

7bdc696

ajay-sentry reviewed Jul 16, 2024

View reviewed changes

ajay-sentry approved these changes Jul 16, 2024

View reviewed changes

reword some things to make them a bit clearer

57750fd

nicholas-codecov added this pull request to the merge queue Jul 17, 2024

Merged via the queue into main with commit 0f04370 Jul 17, 2024
61 checks passed

nicholas-codecov deleted the feat-move-bundle-tab-trend-dropdown branch July 17, 2024 13:43

nicholas-codecov mentioned this pull request Jul 17, 2024

[UI] Move Trend Dropdown codecov/engineering-team#2047

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Move bundle tab trend dropdown #3019

feat: Move bundle tab trend dropdown #3019

nicholas-codecov commented Jul 16, 2024

codecov-qa bot commented Jul 16, 2024 •

edited

Loading

codecov-public-qa bot commented Jul 16, 2024 •

edited

Loading

codecov-notifications bot commented Jul 16, 2024 •

edited

Loading

codecov-staging bot commented Jul 16, 2024 •

edited

Loading

codecov bot commented Jul 16, 2024 •

edited

Loading

codecov bot commented Jul 16, 2024 •

edited

Loading

codecov-releaser commented Jul 16, 2024 •

edited

Loading

ajay-sentry Jul 16, 2024

ajay-sentry Jul 16, 2024

ajay-sentry left a comment

feat: Move bundle tab trend dropdown #3019

feat: Move bundle tab trend dropdown #3019

Conversation

nicholas-codecov commented Jul 16, 2024

Description

Notable Changes

Screenshots

codecov-qa bot commented Jul 16, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Jul 16, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Jul 16, 2024 • edited Loading

Codecov Report

codecov-staging bot commented Jul 16, 2024 • edited Loading

Bundle Report

codecov bot commented Jul 16, 2024 • edited Loading

Bundle Report

codecov bot commented Jul 16, 2024 • edited Loading

Codecov Report

codecov-releaser commented Jul 16, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

ajay-sentry Jul 16, 2024

Choose a reason for hiding this comment

ajay-sentry Jul 16, 2024

Choose a reason for hiding this comment

ajay-sentry left a comment

Choose a reason for hiding this comment

codecov-qa bot commented Jul 16, 2024 •

edited

Loading

codecov-public-qa bot commented Jul 16, 2024 •

edited

Loading

codecov-notifications bot commented Jul 16, 2024 •

edited

Loading

codecov-staging bot commented Jul 16, 2024 •

edited

Loading

codecov bot commented Jul 16, 2024 •

edited

Loading

codecov bot commented Jul 16, 2024 •

edited

Loading

codecov-releaser commented Jul 16, 2024 •

edited

Loading