Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torngit github: retry on 502/503/504 #233

Merged
merged 1 commit into from
Jun 4, 2024
Merged

torngit github: retry on 502/503/504 #233

merged 1 commit into from
Jun 4, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented May 30, 2024

codecov/engineering-team#1757

we sometimes observe 502s and 504s in list_repos(). #232 attempts to mitigate that by testing a smaller page size, but also sometimes retrying 502/503/504 will just work

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (2a8964f) to head (ecd2f58).

Current head ecd2f58 differs from pull request most recent head 5aece51

Please upload reports for the commit 5aece51 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   89.59%   89.49%   -0.10%     
==========================================
  Files         328      324       -4     
  Lines       10481    10373     -108     
  Branches     1915     1903      -12     
==========================================
- Hits         9390     9283     -107     
+ Misses       1024     1020       -4     
- Partials       67       70       +3     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to see how this looks, I'd pay close attention to undesired side effects

@matt-codecov matt-codecov added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 5da2084 Jun 4, 2024
6 checks passed
@matt-codecov matt-codecov deleted the pr233 branch June 4, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants