-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: Add Line Breaks to worker logs #407
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #407 +/- ##
==========================================
- Coverage 97.49% 97.48% -0.01%
==========================================
Files 395 395
Lines 33370 33379 +9
==========================================
+ Hits 32533 32541 +8
- Misses 837 838 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
- Coverage 97.49% 97.48% -0.01%
==========================================
Files 395 395
Lines 33370 33379 +9
==========================================
+ Hits 32533 32541 +8
- Misses 837 838 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #407 +/- ##
==========================================
- Coverage 97.49% 97.48% -0.01%
==========================================
Files 395 395
Lines 33370 33379 +9
==========================================
+ Hits 32533 32541 +8
- Misses 837 838 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
- Coverage 97.51% 97.51% -0.01%
==========================================
Files 426 426
Lines 34070 34079 +9
==========================================
+ Hits 33223 33231 +8
- Misses 847 848 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Similar to what was done for API here codecov/codecov-api#497 , adding line breaks on worker logs (on dev) for easy parsing. One additional change I made compared to API was for lists > 10 items we're just concatenating repoIds onto a single string. This is to prevent an excess of line breaks and too much sparseness in the logs
closes #1657
Screenshots
Before
After
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.