Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add Line Breaks to worker logs #407

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Apr 23, 2024

Similar to what was done for API here codecov/codecov-api#497 , adding line breaks on worker logs (on dev) for easy parsing. One additional change I made compared to API was for lists > 10 items we're just concatenating repoIds onto a single string. This is to prevent an excess of line breaks and too much sparseness in the logs

closes #1657

Screenshots

Before
Screenshot 2024-04-23 at 2 45 24 PM

After
Screenshot 2024-04-23 at 2 41 05 PM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   97.49%   97.48%   -0.01%     
==========================================
  Files         395      395              
  Lines       33370    33379       +9     
==========================================
+ Hits        32533    32541       +8     
- Misses        837      838       +1     
Flag Coverage Δ
integration 97.48% <92.30%> (-0.01%) ⬇️
latest-uploader-overall 97.48% <92.30%> (-0.01%) ⬇️
unit 97.48% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.86% <90.90%> (-0.01%) ⬇️
OutsideTasks 97.53% <92.30%> (-0.01%) ⬇️
Files Coverage Δ
helpers/tests/unit/test_logging_config.py 100.00% <100.00%> (ø)
helpers/logging_config.py 80.85% <90.90%> (+1.90%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.48%. Comparing base (6a3c3b6) to head (67b221a).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   97.49%   97.48%   -0.01%     
==========================================
  Files         395      395              
  Lines       33370    33379       +9     
==========================================
+ Hits        32533    32541       +8     
- Misses        837      838       +1     
Flag Coverage Δ
integration 97.48% <92.30%> (-0.01%) ⬇️
latest-uploader-overall 97.48% <92.30%> (-0.01%) ⬇️
unit 97.48% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.86% <90.90%> (-0.01%) ⬇️
OutsideTasks 97.53% <92.30%> (-0.01%) ⬇️
Files Coverage Δ
helpers/tests/unit/test_logging_config.py 100.00% <100.00%> (ø)
helpers/logging_config.py 80.85% <90.90%> (+1.90%) ⬆️

Copy link

codecov-public-qa bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.48%. Comparing base (6a3c3b6) to head (67b221a).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   97.49%   97.48%   -0.01%     
==========================================
  Files         395      395              
  Lines       33370    33379       +9     
==========================================
+ Hits        32533    32541       +8     
- Misses        837      838       +1     
Flag Coverage Δ
integration 97.48% <92.30%> (-0.01%) ⬇️
latest-uploader-overall 97.48% <92.30%> (-0.01%) ⬇️
unit 97.48% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.86% <90.90%> (-0.01%) ⬇️
OutsideTasks 97.53% <92.30%> (-0.01%) ⬇️
Files Coverage Δ
helpers/tests/unit/test_logging_config.py 100.00% <100.00%> (ø)
helpers/logging_config.py 80.85% <90.90%> (+1.90%) ⬆️

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.51%. Comparing base (6a3c3b6) to head (67b221a).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   97.51%   97.51%   -0.01%     
==========================================
  Files         426      426              
  Lines       34070    34079       +9     
==========================================
+ Hits        33223    33231       +8     
- Misses        847      848       +1     
Flag Coverage Δ
integration 97.48% <92.30%> (-0.01%) ⬇️
latest-uploader-overall 97.48% <92.30%> (-0.01%) ⬇️
unit 97.48% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.87% <90.90%> (-0.01%) ⬇️
OutsideTasks 97.53% <92.30%> (-0.01%) ⬇️
Files Coverage Δ
helpers/tests/unit/test_logging_config.py 100.00% <100.00%> (ø)
helpers/logging_config.py Critical 95.74% <90.90%> (-1.63%) ⬇️

This change has been scanned for critical changes. Learn more

@ajay-sentry ajay-sentry added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 78b8c10 Apr 24, 2024
14 of 30 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/logging-line-breaks branch April 24, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Line breaks to Worker logs
2 participants