Logic to remove checks from team plan customer

services/notification/__init__.py

@@ -13,9 +13,10 @@
 from celery.exceptions import CeleryError, SoftTimeLimitExceeded
 from shared.config import get_config
 from shared.helpers.yaml import default_if_true
+from shared.plan.constants import TEAM_PLAN_REPRESENTATIONS
 from shared.yaml import UserYaml
 
-from database.models.core import GITHUB_APP_INSTALLATION_DEFAULT_NAME
+from database.models.core import GITHUB_APP_INSTALLATION_DEFAULT_NAME, Owner
 from helpers.metrics import metrics
 from services.comparison import ComparisonProxy
 from services.decoration import Decoration
@@ -60,10 +61,13 @@ def _should_use_checks_notifier(self) -> bool:
         if checks_yaml_field is False:
             return False
 
-        owner = self.repository.owner
+        owner: Owner = self.repository.owner
         if owner.service not in ["github", "github_enterprise"]:
             return False
 
+        if owner.plan in TEAM_PLAN_REPRESENTATIONS:
+            return False
+
         app_installation_filter = filter(
             lambda obj: (
                 obj.name == self.gh_installation_name_to_use and obj.is_configured()

services/notification/tests/unit/test_notification_service.py

@@ -5,6 +5,7 @@
 import mock
 import pytest
 from celery.exceptions import SoftTimeLimitExceeded
+from shared.plan.constants import PlanName
 from shared.reports.resources import Report, ReportFile, ReportLine
 from shared.yaml import UserYaml
 
@@ -121,6 +122,23 @@ def test_should_use_checks_notifier_ghapp_all_repos_covered(self, dbsession):
         service = NotificationService(repository, current_yaml)
         assert service._should_use_checks_notifier() == True
 
+    def test_should_not_use_checks_notifier_if_in_team_plan(self, dbsession):
+        repository = RepositoryFactory.create(
+            owner__service="github", owner__plan=PlanName.TEAM_MONTHLY.value
+        )
+        ghapp_installation = GithubAppInstallation(
+            name=GITHUB_APP_INSTALLATION_DEFAULT_NAME,
+            installation_id=456789,
+            owner=repository.owner,
+            repository_service_ids=None,
+        )
+        dbsession.add(ghapp_installation)
+        dbsession.flush()
+        current_yaml = {"github_checks": True}
+        assert repository.owner.github_app_installations == [ghapp_installation]
+        service = NotificationService(repository, current_yaml)
+        assert service._should_use_checks_notifier() == False
+
     @pytest.mark.parametrize(
         "gh_installation_name",
         [GITHUB_APP_INSTALLATION_DEFAULT_NAME, "notifications-app"],