CC-1292: Update log prefix dynamically when reusing connection #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on the number of commands sent from current connection.
rohitpaulk
reviewed
Jun 11, 2024
| @@ -14,7 +14,7 @@ import ( | |||
| type RespConnectionCallbacks struct { | |||
| // BeforeSendCommand is called when a command is sent to the server. | |||
| // This can be useful for info logs. | |||
| BeforeSendCommand func(command string, args ...string) | |||
| BeforeSendCommand func(reusedConnection bool, command string, args ...string) | |||
There was a problem hiding this comment.
Not a big deal since we only have this one use-case, but wanted to leave a note:
A common pattern I've seen for cases like these is to pass in RespConnection itself to the callback - that way the callback has access to everything public on RespConnection, and it helps avoid parameters like reusedConnection which are use-case specific (over time we might have to add new parameters for multiple things that could just be computed off of RespConnection)
rohitpaulk
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
BeforeSendCommandcallback in theRespConnectionCallbacksstruct to include a new parameterreusedConnectionwhich indicates whether the connection is being reused or not. TheBeforeSendCommandcallback is used to log the commands being sent to the server. With this change, the command prefix is dynamically set based on whether the connection is being reused or not. If the connection is reused, the command prefix is set to">", otherwise it is set to "$ redis-cli". This provides more context in the logs when commands are being sent.